groovy

metaClosure not called when using named parameters in Sql.rows

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7.3
  • Fix Version/s: 2.0-beta-3, 1.8.7
  • Component/s: SQL processing
  • Labels:
    None
  • Environment:
    Windows XP SP3, JVM 1.6.0_07
  • Number of attachments :
    0

Description

Running the following code shows the problem:

import groovy.sql.*

def sql = Sql.newInstance([...])

def metaClosure = { meta ->
  meta.each { col ->
    println col.columnName
  }
}

println "Named:"

sql.rows("SELECT COUNT(*) AS Number FROM Table WHERE Id BETWEEN :start AND :end", [start: 10000, end: 11000], metaClosure).each { res ->
  println res[0]
}

println "Ordinal:"

sql.rows("SELECT COUNT(*) AS Number FROM Table WHERE Id BETWEEN ? AND ?", [10000, 11000], metaClosure).each { res ->
  println res[0]
}

Result on my computer:

Named:
994
Ordinal:
Number
994

Showing the metaClosure that prints the column name is not called when using named parameters.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul King added a comment -

What happens if you put your map in a list, e.g.:

[[start: 10000, end: 11000]]

I suspect we don't support metaClosure with the arbitrary params required for ordinal params. We could do some smart looking up of the last param I guess.

Show
Paul King added a comment - What happens if you put your map in a list, e.g.: [[start: 10000, end: 11000]] I suspect we don't support metaClosure with the arbitrary params required for ordinal params. We could do some smart looking up of the last param I guess.
Hide
Permalink
Roshan Dawrani added a comment -

Yes, method selection seems at fault here.

For the args (String, Map params, Closure), it chooses rows(String query, Object[] params) over rows(String query, List params, Closure metaClosure) and thus metaClosure fails to get executed.

Show
Roshan Dawrani added a comment - Yes, method selection seems at fault here. For the args (String, Map params, Closure), it chooses rows(String query, Object[] params) over rows(String query, List params, Closure metaClosure) and thus metaClosure fails to get executed.
Hide
Permalink
Roshan Dawrani added a comment -

For me, wrapping params in a list as [[start: 1, end: 5]] worked.

Show
Roshan Dawrani added a comment - For me, wrapping params in a list as [ [start: 1, end: 5] ] worked.
Hide
Permalink
Roshan Dawrani added a comment - - edited

Paul, the javadoc of Sql#rows(String sql, List<Object> params, Closure metaClosure) needs to be updated if metaClosure support is not there with arbitrary params required for ordinal params.

Javadoc for the metaClosure version of rows() can be updated with a named parameter example (with the extra list wrapping)

Show
Roshan Dawrani added a comment - - edited Paul, the javadoc of Sql#rows(String sql, List<Object> params, Closure metaClosure) needs to be updated if metaClosure support is not there with arbitrary params required for ordinal params. Javadoc for the metaClosure version of rows() can be updated with a named parameter example (with the extra list wrapping)
Hide
Permalink
Paul King added a comment -

Roshan, are you suggesting some clarification, e.g. changing this:

This method supports named and named ordinal parameters.

to this:

This method supports named and named ordinal parameters by supplying such parameters in the params list.

Show
Paul King added a comment - Roshan, are you suggesting some clarification, e.g. changing this: This method supports named and named ordinal parameters. to this: This method supports named and named ordinal parameters by supplying such parameters in the params list.
Hide
Permalink
Roshan Dawrani added a comment -

Yes. The current javadoc has the following example:

sql.rows("select * from PERSON where lastname like ?", ['%a%'], metaClosure)

but there is no named parameters example, and the first natural attempt is probably to try 

sql.rows("select * from PERSON where lastname like :alastname", [alastname: '%a%'], metaClosure)

but what the current method selection logic requires is

sql.rows("select * from PERSON where lastname like :alastname", [[alastname: '%a%']], metaClosure)

I think this point/example needs to come in the javadoc - as it suits best.

Show
Roshan Dawrani added a comment - Yes. The current javadoc has the following example: sql.rows( "select * from PERSON where lastname like ?" , ['%a%'], metaClosure) but there is no named parameters example, and the first natural attempt is probably to try sql.rows( "select * from PERSON where lastname like :alastname" , [alastname: '%a%'], metaClosure) but what the current method selection logic requires is sql.rows( "select * from PERSON where lastname like :alastname" , [[alastname: '%a%']], metaClosure) I think this point/example needs to come in the javadoc - as it suits best.
Hide
Permalink
Paul King added a comment -

Comment updated.

Wondering whether we can do some smarts to detect when a (meta) closure is the last param for the Object[] case. And allow that method to also support named and ordinal params.

Show
Paul King added a comment - Comment updated. Wondering whether we can do some smarts to detect when a (meta) closure is the last param for the Object[] case. And allow that method to also support named and ordinal params.
Hide
Permalink
Roshan Dawrani added a comment -

Wondering whether we will then want to go beyond the last param and do smarts for detecting the following method as well, for example:

def foo(String, List, Closure, Closure){...}
Show
Roshan Dawrani added a comment - Wondering whether we will then want to go beyond the last param and do smarts for detecting the following method as well, for example: def foo( String , List, Closure, Closure){...}
Hide
Permalink
Paul King added a comment -

The fix for GROOVY-5405 should also fix this issue. Let me know if you have any further problems.

Show
Paul King added a comment - The fix for GROOVY-5405 should also fix this issue. Let me know if you have any further problems.

People

  • Assignee:
    Paul King
    Reporter:
    Alain Perry
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: