groovy

Extra ";" is added in template where it's not needed

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.7.2
  • Fix Version/s: None
  • Component/s: Groovlet / GSP
  • Labels:
    None
  • Number of attachments :
    0

Description

The following Groovy code:

<properties>
    <hudson.model.ParametersDefinitionProperty>
        <parameterDefinitions>
<%
    job.parameters().each
    {
        Parameter p ->

        switch ( p.type )
        {
            case ParameterType.bool:
%>
            <hudson.model.BooleanParameterDefinition>
            </hudson.model.BooleanParameterDefinition>
<%
                 break
        }
    }
%>
        </parameterDefinitions>
    </hudson.model.ParametersDefinitionProperty>
</properties>

created the following template

out.print("<properties>\n");
out.print("    <hudson.model.ParametersDefinitionProperty>\n");
out.print("        <parameterDefinitions>\n");
out.print("");
    job.parameters().each
    {
        Parameter p ->

        switch ( p.type )
        {
            case ParameterType.bool:
;
out.print("\n");
out.print("            <hudson.model.BooleanParameterDefinition>\n");
out.print("            </hudson.model.BooleanParameterDefinition>\n");
out.print("");
                 break
        }
    }
;
out.print("\n");
out.print("        </parameterDefinitions>\n");
out.print("    </hudson.model.ParametersDefinitionProperty>\n");
out.print("</properties>\n");

Now it fails due to ";" on line 12: unexpected token: ;

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Evgeny Goldin added a comment -

Sorry, it's not a Groovy code but a GSP template, of course

Show
Evgeny Goldin added a comment - Sorry, it's not a Groovy code but a GSP template, of course
Hide
Permalink
Evgeny Goldin added a comment -

The fix is

<%
    job.parameters().each
    {
        Parameter p ->

        switch ( p.type )
        {
            case ParameterType.bool:
                def j // http://jira.codehaus.org/browse/GROOVY-4236
%>
            <hudson.model.BooleanParameterDefinition>
            </hudson.model.BooleanParameterDefinition>
<%
                 break
        }
    }
%>

which causes the following template to be created:

    job.parameters().each
    {
        Parameter p ->

        switch ( p.type )
        {
            case ParameterType.bool:
                def j // http://jira.codehaus.org/browse/GROOVY-4236
;
out.print("\n");
out.print("            <hudson.model.BooleanParameterDefinition>\n");
out.print("            </hudson.model.BooleanParameterDefinition>\n");
out.print("");
                 break
        }
    }
;

and it works now

Show
Evgeny Goldin added a comment - The fix is <% job.parameters().each { Parameter p -> switch ( p.type ) { case ParameterType.bool: def j // http://jira.codehaus.org/browse/GROOVY-4236 %> <hudson.model.BooleanParameterDefinition> </hudson.model.BooleanParameterDefinition> <% break } } %> which causes the following template to be created: job.parameters().each { Parameter p -> switch ( p.type ) { case ParameterType.bool: def j // http://jira.codehaus.org/browse/GROOVY-4236 ; out.print( "\n" ); out.print( " <hudson.model.BooleanParameterDefinition>\n" ); out.print( " </hudson.model.BooleanParameterDefinition>\n" ); out.print(""); break } } ; and it works now
Hide
Permalink
Roshan Dawrani added a comment -

I am not sure if template code generator can understand the code around groovy-sections (<% %>) and figure out whether it is legal to put statement separator (";") to mark the end of section or not.

May be someone else has any suggestion if anything can be done about it. Otherwise, it may be one of the the quirks that you have to know and workaround.

Show
Roshan Dawrani added a comment - I am not sure if template code generator can understand the code around groovy-sections (<% %>) and figure out whether it is legal to put statement separator (";") to mark the end of section or not. May be someone else has any suggestion if anything can be done about it. Otherwise, it may be one of the the quirks that you have to know and workaround.
Hide
Permalink
Guillaume Laforge added a comment -

The template engine is a bit "dumb", in the sense that it doesn't really know about the kind of code surrounding the verbatim text.
We'd need a full-blown grammar and parser to do so, and that would be a pretty extensive rewrite of the whole engine.
So as Roshan puts it, we have to live with the quircks

Show
Guillaume Laforge added a comment - The template engine is a bit "dumb", in the sense that it doesn't really know about the kind of code surrounding the verbatim text. We'd need a full-blown grammar and parser to do so, and that would be a pretty extensive rewrite of the whole engine. So as Roshan puts it, we have to live with the quircks
Hide
Permalink
blackdrag blackdrag added a comment -

So unless there is disagreement I close this

Show
blackdrag blackdrag added a comment - So unless there is disagreement I close this
Hide
Permalink
Evgeny Goldin added a comment -

Sure, I can live with workaround. Many thanks for the fast responses, guys!

Show
Evgeny Goldin added a comment - Sure, I can live with workaround. Many thanks for the fast responses, guys!

People

  • Assignee:
    blackdrag blackdrag
    Reporter:
    Evgeny Goldin
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: