groovy

DOMCategory.setValue is unable to handle newly created elements

Details

  • Number of attachments :
    0

Description

If a newly created element has no children then a NullPointerException is thrown.

IMO in these cases the method should create a new TextElement and add the contents to it.

How to reproduce:

import groovy.xml.dom.DOMCategory

use(DOMCategory) {
    def prop = doc.createElement('property')
    prop.setAttribute('name', 'cache.class')
    prop.setValue('true')
}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul King added a comment -

add code tags

Show
Paul King added a comment - add code tags
Paul King made changes -
Field Original Value New Value
Description If a newly created element has no children then a NullPointerException is thrown.

IMO in these cases the method should create a new TextElement and add the contents to it.

How to reproduce:

import groovy.xml.dom.DOMCategory

use(DOMCategory) {
    def prop = doc.createElement('property')
    prop.setAttribute('name', 'cache.class')
    prop.setValue('true')
}
If a newly created element has no children then a NullPointerException is thrown.

IMO in these cases the method should create a new TextElement and add the contents to it.

How to reproduce:
{code}
import groovy.xml.dom.DOMCategory

use(DOMCategory) {
    def prop = doc.createElement('property')
    prop.setAttribute('name', 'cache.class')
    prop.setValue('true')
}
{code}
Hide
Permalink
Marek Baluch added a comment -

Thanks for the tip.

Show
Marek Baluch added a comment - Thanks for the tip.
Hide
Permalink
Paul King added a comment -

I believe this was fixed as part of GROOVY-5280. Let me know if you have any further problems. Thanks for reporting the issue.

Show
Paul King added a comment - I believe this was fixed as part of GROOVY-5280 . Let me know if you have any further problems. Thanks for reporting the issue.
Paul King made changes -
Status Open [ 1 ] Closed [ 6 ]
Assignee Paul King [ paulk ]
Fix Version/s 2.0-beta-3 [ 18244 ]
Fix Version/s 1.8.6 [ 18245 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Paul King
    Reporter:
    Marek Baluch
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: