groovy

groovy.util.GroovyScriptEngine.loadScriptByName does not accept scripts without ".groovy" extension

Details

  • Type: Wish Wish
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 1.7.2
  • Fix Version/s: None
  • Component/s: class generator
  • Labels:
    None
  • Number of attachments :
    0

Description

Hi,

In version 1.6.5 the API groovy.util.GroovyScriptEngine.loadScriptByName used to accept groovy script name with extension.
Now I have installed 1.7.2 and it is throwing exception for groovy script name without extension.

Please let me know if this is bug or done purposely, so that I can change my code accordingly

Thanks,
Rajendra

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roshan Dawrani added a comment -

What is the exception you are getting? I just tried a script without any file extension and didn't have any issue in calling groovy.util.GroovyScriptEngine.loadScriptByName() - on both 1.7.x as well as 1.8.x.

Show
Roshan Dawrani added a comment - What is the exception you are getting? I just tried a script without any file extension and didn't have any issue in calling groovy.util.GroovyScriptEngine.loadScriptByName() - on both 1.7.x as well as 1.8.x.
Hide
Permalink
Roshan Dawrani added a comment -

I again tried and both without extension and with a non ".groovy" extension, GroovyScriptEngine#loadScriptByName() works just fine.

Please reopen with the steps to reproduce if encountered again.

Show
Roshan Dawrani added a comment - I again tried and both without extension and with a non ".groovy" extension, GroovyScriptEngine#loadScriptByName() works just fine. Please reopen with the steps to reproduce if encountered again.
Hide
Permalink
Roshan Dawrani added a comment -

I understand the issue only now.

In 1.6.x, if the script is Foo.groovy, GSE#loadScriptByName("Foo") works (infact GSE#loadScriptByName("Foo.groovy") does not work because the method always append ".groovy")

In 1.7.x+, it is other way round loadScriptByName() does not append ".groovy", so only GSE#loadScriptByName("Foo.groovy") and not GSE#loadScriptByName("Foo")

Was it an intentional change in GSE rewrite? Not sure how well it has come out in the documentation, etc.

Can someone please confirm?

Show
Roshan Dawrani added a comment - I understand the issue only now. In 1.6.x, if the script is Foo.groovy, GSE#loadScriptByName("Foo") works (infact GSE#loadScriptByName("Foo.groovy") does not work because the method always append ".groovy") In 1.7.x+, it is other way round loadScriptByName() does not append ".groovy", so only GSE#loadScriptByName("Foo.groovy") and not GSE#loadScriptByName("Foo") Was it an intentional change in GSE rewrite? Not sure how well it has come out in the documentation, etc. Can someone please confirm?
Hide
Permalink
blackdrag blackdrag added a comment -

but Roshan... what you say is the opposite of what Rajendra did say... but I can say that a change in that area was not intended

Show
blackdrag blackdrag added a comment - but Roshan... what you say is the opposite of what Rajendra did say... but I can say that a change in that area was not intended
Hide
Permalink
Roshan Dawrani added a comment -

Jochen, I think JIRA description has a typo and he meant that "GSE.loadScriptByName used to accept groovy script name without extension." because the JIRA title says it correctly and that is where the issue lies.

Another GSE feature that has been lost is that earlier under a specific root (say, c:), if I has com\foo\Bar.groovy, I could say GSE.loadScriptByName("com.foo.Bar") - it used to convert package name to path and then make it "c:\" + "com\foo\Bar" + ".groovy". On the new version the same becomes "c:\com.foo.Bar", which is wrong in 2 ways - no package to path conversion and no appending of extension.

If now changed, will it be considered a breaking change for 1.7.x? I personally think it must change back to as it was.

Show
Roshan Dawrani added a comment - Jochen, I think JIRA description has a typo and he meant that "GSE.loadScriptByName used to accept groovy script name without extension." because the JIRA title says it correctly and that is where the issue lies. Another GSE feature that has been lost is that earlier under a specific root (say, c:), if I has com\foo\Bar.groovy, I could say GSE.loadScriptByName("com.foo.Bar") - it used to convert package name to path and then make it "c:\" + "com\foo\Bar" + ".groovy". On the new version the same becomes "c:\com.foo.Bar", which is wrong in 2 ways - no package to path conversion and no appending of extension. If now changed, will it be considered a breaking change for 1.7.x? I personally think it must change back to as it was.
Hide
Permalink
Rainer Schmitz added a comment -

I can reproduce both bugs (file name must contain '.groovy' and '.' have to be replaced by '/') in Groovy 1.7.5.
GroovyScriptEngine is instantiated using GroovyScriptEngine(String[] urls, ClassLoader parentClassLoader) constructor:

String path = ['test/unit/', 'erprest/test/unit/']
GroovyScriptEngine engine = new GroovyScriptEngine(path, Thread.currentThread().getContextClassLoader())

Show
Rainer Schmitz added a comment - I can reproduce both bugs (file name must contain '.groovy' and '.' have to be replaced by '/') in Groovy 1.7.5. GroovyScriptEngine is instantiated using GroovyScriptEngine(String[] urls, ClassLoader parentClassLoader) constructor: String path = ['test/unit/', 'erprest/test/unit/'] GroovyScriptEngine engine = new GroovyScriptEngine(path, Thread.currentThread().getContextClassLoader())

People

  • Assignee:
    Roshan Dawrani
    Reporter:
    Rajendra Kothari
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: