Can't call Java varargs method when it's mixed in to toplevel

One ugly workaround until fixed:

varargs(["a", "b"] as Object[])

Also noted that normal category usage appears to work fine:

use(Dsl) {
    varargs("a", "b")
}

Just debugging what is happening (using the above script):

println this.metaClass.methods.grep(~'.*vararg.*').join('\n')

yields:

org.codehaus.groovy.runtime.metaclass.MixinInstanceMetaMethod@1cd2d49[name: varargs params: [class [Ljava.lang.Object;] returns: void owner: class ConsoleScript9]
org.codehaus.groovy.runtime.metaclass.MixinInstanceMetaMethod@12a09d5[name: novarargs params: [interface java.util.List] returns: void owner: class ConsoleScript9]

In fact, once this is run:

varargs(["a", "b"] as Object[])

then this works from that point on:

varargs("a", "b")

Planning on applying the attached patch in a day or two unless someone can think of a better way to fix this.

Paul, that might fix varargs(Object... s), but it does not fix varargs(String... s) or varargs(Object a, Object... s) or most other cases. So I am for not applying that patch, it leads to the false assumption the bug has been fixed and will later cause problems again

Yes, I found the first case you mentioned straight after posting the previous patch. I assumed the second case was not broken but it too is broken. Looks better to hook into some existing code if we can.

Attaching an alternative patch for review and its test files.

Test can be run as:

javac NewDsl.java && groovy TestNewDsl.groovy

Attaching a slightly easier version of TestNewDsl.groovy for review.

looks good to me

I had a similar solution to Roshan's though I had to do a pre-emptive call to method.getParameterTypes() in order for the testcase that I added to pass. The only difference is that my testcase uses a Groovy mixin class and is located in the same script. It would be nice to push that logic somewhere else but I haven't had time yet to investigate.

Thanks for fixing this guys!