groovy

Allow methodMissing/propertyMissing to be defined through category

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.6.5
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

When integrating a library defined by a 3rd party into Groovy, it's often convenient to be able to define missing method/property receiver. Since I can't modify the library directly, it would be great if this can be achieved via category.

In the current MetaClassImpl implementation, category isn't searched for a missing method/property receiver.

Note that the generic "Object get(String name)" serves as a replacement for propertyMissing, but there's nothing like that for methods. Plus the get method isn't invoked for "foo.someMethod(...)" even though it works for "(foo.someMethod)(...)" due to the difference in the property look up and method invocation handling.

Activity

Ascending order - Click to sort in descending order
Guillaume Laforge made changes -
Field Original Value New Value
Fix Version/s 1.8-beta-1 [ 15750 ]
Hide
Permalink
Merlyn Albery-Speyer added a comment - - edited

Attached is a test that fails:

class MetaClassImplTest extends GroovyTestCase {
    void testExtensionByCategory() {
        assertScript """
            @Category(String)
            class StringCategory {
                def methodMissing(String name, args) {
                    return "methodMissing $name"
                }
                
                def bar() {
                	return "normal method"
                }
            }
            
            use(StringCategory) {
                assert "aString".bar() == "normal method"
                assert "aString".foo() == "methodMissing foo"
            }
        """
    }
}
Show
Merlyn Albery-Speyer added a comment - - edited Attached is a test that fails: class MetaClassImplTest extends GroovyTestCase { void testExtensionByCategory() { assertScript """ @Category( String ) class StringCategory { def methodMissing( String name, args) { return "methodMissing $name" } def bar() { return "normal method" } } use(StringCategory) { assert "aString" .bar() == "normal method" assert "aString" .foo() == "methodMissing foo" } """ } }
Merlyn Albery-Speyer made changes -
Attachment categoryAndMissingMethodFailingTest.patch [ 46620 ]
Merlyn Albery-Speyer made changes -
Attachment categoryAndMissingMethodFailingTest.patch [ 46620 ]
Hide
Permalink
Merlyn Albery-Speyer added a comment -

Corrected the attached test.

Show
Merlyn Albery-Speyer added a comment - Corrected the attached test.
Merlyn Albery-Speyer made changes -
Attachment categoryAndMissingMethodFailingTest.patch [ 46675 ]
Hide
Permalink
Merlyn Albery-Speyer added a comment -

Test fails on the second assertion:

    [junit] groovy.lang.MissingMethodException: No signature of method: java.lang.String.foo() is applicable for argument types: () values: []
Show
Merlyn Albery-Speyer added a comment - Test fails on the second assertion: [junit] groovy.lang.MissingMethodException: No signature of method: java.lang. String .foo() is applicable for argument types: () values: []
Pascal Schumacher made changes -
Fix Version/s 1.8.x [ 15750 ]
Hide
Permalink
Pascal Schumacher added a comment -

Is this something for Groovy 3?

Show
Pascal Schumacher added a comment - Is this something for Groovy 3?

People

  • Assignee:
    Unassigned
    Reporter:
    Kohsuke Kawaguchi
Vote (1)
Watch (2)

Dates

  • Created:
    Updated: