groovy

Byte code generator (used by GroovyScriptEngine, GroovyShell & GroovyClassLoader) flag invalid methods

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.6.5, 1.7-beta-2
  • Fix Version/s: None
  • Component/s: class generator
  • Labels:
    None
  • Number of attachments :
    0

Description

When generating code for the Groovy compiler, one frequently exceeds the Class file format limit on method size. The resulting ClassFormatError from the ClassLoader doesn't effectively point at the problem. In addition, the Error is not a type of Exception and so is not picked up by conventional logging.

Ideally, the methods that generate class files would abort code-generation and throw a type of Exception when the generated method exceeds the limit imposed by the class file format.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roshan Dawrani added a comment -

org.objectweb.asm.MethodWriter has this package-private method called getSize() that could have been used by ACG to validate the code length of the method it generates. But alas, ASM obfuscates it!

Show
Roshan Dawrani added a comment - org.objectweb.asm.MethodWriter has this package-private method called getSize() that could have been used by ACG to validate the code length of the method it generates. But alas, ASM obfuscates it!
Hide
Permalink
Roshan Dawrani added a comment -

If ClassWriter#getSize() could have been used, there would have been almost no extra cost and size could have been checked as the methods got written.

A more expensive option would be to read the class byte array and look at method attributes and validate the method length using "Code" method attribute.

Show
Roshan Dawrani added a comment - If ClassWriter#getSize() could have been used, there would have been almost no extra cost and size could have been checked as the methods got written. A more expensive option would be to read the class byte array and look at method attributes and validate the method length using "Code" method attribute.

People

  • Assignee:
    blackdrag blackdrag
    Reporter:
    John Bito
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: