groovy

Tiny improvement to groovy.sql.Sql eachRows()

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.7.x
  • Fix Version/s: 1.6.6, 1.7-rc-1
  • Component/s: SQL processing
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

A tiny improvement to eachRow().

Change

while (groovyRS.next()) { rowClosure.call(groovyRS); }

to

groovyRS.eachRow(rowClosure);

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
blackdrag blackdrag added a comment -

Looks like GroovyResultSet may update the row, while the current code doesn't do that. Is it still equal then?

Show
blackdrag blackdrag added a comment - Looks like GroovyResultSet may update the row, while the current code doesn't do that. Is it still equal then?
Hide
Permalink
John Hurst added a comment -

I guess I was basing my change on the implementation of GroovyResultSetExtension.eachRow():

public void eachRow(Closure closure) throws SQLException {
while (next()) { closure.call(this); }
}

Is this not a safe assumption? (Is that what you're getting at?)

Show
John Hurst added a comment - I guess I was basing my change on the implementation of GroovyResultSetExtension.eachRow(): public void eachRow(Closure closure) throws SQLException { while (next()) { closure.call(this); } } Is this not a safe assumption? (Is that what you're getting at?)
Hide
Permalink
Paul King added a comment -

Fix applied. Thanks.

Show
Paul King added a comment - Fix applied. Thanks.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.