groovy

GroovyConsole AST Viewer command line interface broken

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7-beta-1
  • Fix Version/s: 1.7-beta-1
  • Component/s: Groovy Console
  • Labels:
    None
  • Environment:
    All. Tested on WinXP
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

The AstBrowser class has a main method with the following javadoc: 

/**
 * This object is a GUI for looking at the AST that Groovy generates. 
 * 
 * Usage: groovy AstBrowser [filename]
 *         where [filename] is an existing Groovy script. 
*/

The addition of line number highlighting into the browser broke this feature.

The attached fix does the following:

  • makes the command line interface work again but allowing null inputArea and rootElement
  • prints stack traces if an error occurs (this is a broader issue with error reporting in Ast Browser)
  • Updates the java doc to show the true usage.

This is a main method that creates a heavyweight frame... so I didn't write a unit test.

  1. Text File
    ast_console_commandline.patch
    31/May/09 11:01 AM
    4 kB
    Hamlet D'Arcy
  2. Text File
    ast_console_commandline2.patch
    31/May/09 6:27 PM
    4 kB
    Hamlet D'Arcy

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hamlet D'Arcy added a comment -

This 2nd patch also fixes the look and feel so that it is the same as the GroovyConsole when invoked from the command line.

Show
Hamlet D'Arcy added a comment - This 2nd patch also fixes the look and feel so that it is the same as the GroovyConsole when invoked from the command line.
Hide
Permalink
Paul King added a comment -

I noticed that you changed the javadoc to run from java not groovy. Is that intentional?

Show
Paul King added a comment - I noticed that you changed the javadoc to run from java not groovy. Is that intentional?
Hide
Permalink
Hamlet D'Arcy added a comment -

I changed the example usage to java because that is how I envision people using it more frequently. The javadoc should probably read:

java -cp .groovy.inspect.swingui.AstBrowser [filename]

Most people will not have the AstBrowser.groovy file on their system because they'll have the groovy-all jar in their classpath instead. So invoking java is a more universal usage.

Does groovy even accept a classname as an input parameter on the command line?

Show
Hamlet D'Arcy added a comment - I changed the example usage to java because that is how I envision people using it more frequently. The javadoc should probably read: java -cp .groovy.inspect.swingui.AstBrowser [filename] Most people will not have the AstBrowser.groovy file on their system because they'll have the groovy-all jar in their classpath instead. So invoking java is a more universal usage. Does groovy even accept a classname as an input parameter on the command line?
Hide
Permalink
Paul King added a comment -

Yes, you are right. Java is what makes sense. Anyhow, patch now added to trunk.

Show
Paul King added a comment - Yes, you are right. Java is what makes sense. Anyhow, patch now added to trunk.

People

  • Assignee:
    Paul King
    Reporter:
    Hamlet D'Arcy
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
2h
Original Estimate - 2 hours
Remaining:
2h
Remaining Estimate - 2 hours
Logged:
Not Specified
Time Spent - Not Specified