groovy

VerbatimGStringTest failures - Windows vs. Unix EOL problem

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-5
  • Fix Version/s: 1.0-beta-5
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

VerbatimGStringTest.groovy fails with latest CVS HEAD (4/2/04)

The test results contain "Expression: (string == Bob hey," followed by a UNIX EOL (0a) but contain "Values: string = Bob hey," followed by a Windows EOL (0d0a).

I checked the test case source and it contains a Windows EOL in the
heredoc and a "\n" in the assertion. So... it appears that somewhere along the line the GString is getting a UNIX EOL where there used to be a Windows EOL.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Poirier added a comment -

The lexer preserves eol markers verbatim when processing multiline strings and heredocs. I think this is the correct behaviour. As a result, I think I'm going to change the test framework to convert assertion strings to a common eol before comparison.

Show
Chris Poirier added a comment - The lexer preserves eol markers verbatim when processing multiline strings and heredocs. I think this is the correct behaviour. As a result, I think I'm going to change the test framework to convert assertion strings to a common eol before comparison.
Hide
Permalink
Chris Poirier added a comment -

I think this is fixed (I changed the test case to convert EOLs to \n before testing). Rod: please test this on your system and add a comment if there is still a problem. Thanks.

Show
Chris Poirier added a comment - I think this is fixed (I changed the test case to convert EOLs to \n before testing). Rod: please test this on your system and add a comment if there is still a problem. Thanks.

People

  • Assignee:
    Unassigned
    Reporter:
    Rod Cope
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: