groovy

Method call on instance of java.lang.Class is dispatched to equally named static method on class described by instance

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.6.3
  • Fix Version/s: 1.8.x, 2.x
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    0

Description

class JavaLangClassUsageTest extends GroovyTestCase {
  void testCallFooGetNameMethod() {
    assert Foo.getName() == "Foo.getName" // passes
  }

  void testCallJavaLangClassGetNameMethod() {
    def clazz = new Foo().getClass()
    assert clazz.getName() == "Foo" // fails, actual: Foo.getName
  }
}

class Foo {
  static getName() { "Foo.getName" }
}

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. GROOVY-3549 Usage of ".class" to disambiguate between methods

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Peter Niederwieser made changes -
Field Original Value New Value
Link This issue is related to GROOVY-3549 [ GROOVY-3549 ]
Guillaume Laforge made changes -
Fix Version/s 1.7-beta-1 [ 14014 ]
Fix Version/s 1.7-beta-x [ 15538 ]
blackdrag blackdrag made changes -
Assignee Jochen Theodorou [ blackdrag ]
Hide
Permalink
blackdrag blackdrag added a comment -

Paul I found some code in StaticImportVisitor that may cause this issue here. It is changing a MethodCallExpression with a ClassExpression as receiver into a StaticMethodCallExpression and in the act it changes the receiver to the current class, which may not be what the ClassExpression is refering to.

Show
blackdrag blackdrag added a comment - Paul I found some code in StaticImportVisitor that may cause this issue here. It is changing a MethodCallExpression with a ClassExpression as receiver into a StaticMethodCallExpression and in the act it changes the receiver to the current class, which may not be what the ClassExpression is refering to.
blackdrag blackdrag made changes -
Assignee Jochen Theodorou [ blackdrag ] Paul King [ paulk ]
Hide
Permalink
Roshan Dawrani added a comment -

I think the compilation is happening fine in this case and no StaticImportVisitor issue is in the picture here. The receiever correctly comes as "class Foo" returned by "new Foo().getClass()".

The problem seems to be in MetaClassImpl#createStaticSite() logic, which is mapping it to Foo#getName().

Show
Roshan Dawrani added a comment - I think the compilation is happening fine in this case and no StaticImportVisitor issue is in the picture here. The receiever correctly comes as "class Foo" returned by "new Foo().getClass()". The problem seems to be in MetaClassImpl#createStaticSite() logic, which is mapping it to Foo#getName().
Hide
Permalink
Paul King added a comment - - edited

Roshan, yes I've moved the bug Jochen is referring to into a different issue: GROOVY-3949.

Show
Paul King added a comment - - edited Roshan, yes I've moved the bug Jochen is referring to into a different issue: GROOVY-3949 .
Paul King made changes -
Assignee Paul King [ paulk ]
blackdrag blackdrag made changes -
Fix Version/s 1.8.x [ 15750 ]
Fix Version/s 2.x [ 17013 ]
Fix Version/s 1.7.x [ 15538 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Peter Niederwieser
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: