jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • groovy
  • GROOVY-3480

Spring AOP proxies broken

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.6.1
  • Fix Version/s: 1.6.3, 1.7-beta-1
  • Component/s: None
  • Labels:
    None

Description

The fix for GROOVY-3433 has caused a regression which breaks AOP proxies. It seems that fix is not appropriate and if it is rolled back GROOVY-3433 will need to be re-opened. The reason for the breakage appears to be that Groovy is completely bypassing the proxying mechanism of Spring and going directly to the underlying proxied object hence any Spring AOP advice is not applied to a Groovy object.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. XML File
    ivysettings.xml
    20/Apr/09 8:56 AM
    1 kB
    Graeme Rocher
  2. File
    TestScript.groovy
    20/Apr/09 8:56 AM
    2 kB
    Graeme Rocher

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
blackdrag blackdrag added a comment - 24/Apr/09 3:46 PM

as discussed in GROOVY-3433 I close this one as "won't fix" too

Show
blackdrag blackdrag added a comment - 24/Apr/09 3:46 PM as discussed in GROOVY-3433 I close this one as "won't fix" too
Hide
Permalink
Graeme Rocher added a comment - 28/Apr/09 4:25 PM

Guys as I said said in GROOVY-3433 the fix for that change needed to be rolled back in order for this bug to be closed. I was very explicit about that in my dicussions with both Jochen and Guillaume and in my comment on the issue:

http://jira.codehaus.org/browse/GROOVY-3433?focusedCommentId=173642&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_173642

However, the change hasn't been rolled back at all and in fact there is nothing in the SVN logs that shows that it has been rolled back and Spring proxies as well as Grails test continue to be broken with 1.6.2

It seems not even the test attached to this issue was included in the Groovy build which I would have thought would have been a minimum requirement to avoid regression and would have caught the problem before a release was done. Anyway so it looks like we need Groovy 1.6.3 now which is a rather embarassing situation to be in.

Show
Graeme Rocher added a comment - 28/Apr/09 4:25 PM Guys as I said said in GROOVY-3433 the fix for that change needed to be rolled back in order for this bug to be closed. I was very explicit about that in my dicussions with both Jochen and Guillaume and in my comment on the issue: http://jira.codehaus.org/browse/GROOVY-3433?focusedCommentId=173642&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_173642 However, the change hasn't been rolled back at all and in fact there is nothing in the SVN logs that shows that it has been rolled back and Spring proxies as well as Grails test continue to be broken with 1.6.2 It seems not even the test attached to this issue was included in the Groovy build which I would have thought would have been a minimum requirement to avoid regression and would have caught the problem before a release was done. Anyway so it looks like we need Groovy 1.6.3 now which is a rather embarassing situation to be in.
Hide
Permalink
blackdrag blackdrag added a comment - 28/Apr/09 5:12 PM - edited

you said the changes needs to be rolled back, I did that for 1.6.x. actually I accidentally mixed that into another commit, which caused the build to break and in the next commit I removed the test Alex added for GROOVY-3433, since that one is now no longer working... prove that the change has been rolled back. See http://svn.groovy.codehaus.org/browse/groovy/branches/GROOVY_1_6_X/src/main/org/codehaus/groovy/runtime/callsite/AbstractCallSite.java?r1=15902&r2=16093 for details. The change was http://svn.groovy.codehaus.org/browse/groovy/branches/GROOVY_1_6_X/src/main/org/codehaus/groovy/runtime/callsite/AbstractCallSite.java?r1=14182&r2=15768 or not?

But you are right, the test does not work. I should have looked after that.

Show
blackdrag blackdrag added a comment - 28/Apr/09 5:12 PM - edited you said the changes needs to be rolled back, I did that for 1.6.x. actually I accidentally mixed that into another commit, which caused the build to break and in the next commit I removed the test Alex added for GROOVY-3433, since that one is now no longer working... prove that the change has been rolled back. See http://svn.groovy.codehaus.org/browse/groovy/branches/GROOVY_1_6_X/src/main/org/codehaus/groovy/runtime/callsite/AbstractCallSite.java?r1=15902&r2=16093 for details. The change was http://svn.groovy.codehaus.org/browse/groovy/branches/GROOVY_1_6_X/src/main/org/codehaus/groovy/runtime/callsite/AbstractCallSite.java?r1=14182&r2=15768 or not? But you are right, the test does not work. I should have looked after that.
Hide
Permalink
blackdrag blackdrag added a comment - 28/Apr/09 6:14 PM

After looking more into that I now know that you did mean http://svn.groovy.codehaus.org/changelog/groovy?cs=15848 I didn't find this before because this revision is not tied to GROOVY-3433

Show
blackdrag blackdrag added a comment - 28/Apr/09 6:14 PM After looking more into that I now know that you did mean http://svn.groovy.codehaus.org/changelog/groovy?cs=15848 I didn't find this before because this revision is not tied to GROOVY-3433

People

  • Assignee:
    blackdrag blackdrag
    Reporter:
    Graeme Rocher
Vote (5)
Watch (5)

Dates

  • Created:
    20/Apr/09 8:56 AM
    Updated:
    14/May/09 4:12 AM
    Resolved:
    14/May/09 4:12 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.