groovy

Groovy fails to launch scripts from Cygwin

Details

  • Number of attachments :
    0

Description

Here it is:

$ groovy -version
Groovy Version: 1.6.0 JVM: 1.6.0_12

I have the following script that I put in my $HOME/bin on cygwin, where $HOME maps to regular Windows home: C:\Documents and Settings[my_username]

[my_username] ~/bin
$ cat test.groovy

def f = new File(args[0])
println f.listFiles()

Now I try to run it from c:

[my_username] /cygdrive/c

$ groovy /cygdrive/c/Documents\ and\ Settings/[my_username]/bin/test.groovy .

/cygdrive/c/Program Files/Groovy/Groovy-1.6.0/bin/startGroovy: line 227: and: command not found
Caught: java.lang.IllegalArgumentException: C:\ (C:) is a directory not a Groovy source file.

I do think this is a bug in startGroovy script.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Cold Dimsum added a comment -

I am currently testing out this patch in my cygwin environment, so far so good:

% diff -u startGroovy.DIST startGroovy
— startGroovy.DIST 2009-07-07 22:40:47.140625000 -0500
+++ startGroovy 2009-07-07 23:53:42.828125000 -0500
@@ -218,10 +218,9 @@
for arg in "$@" ; do
CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -`
if [ $CHECK -ne 0 ] ; then

  • eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"`
  • else
  • eval `echo args$i`="\"$arg\""
    + arg=`cygpath --path --ignore --mixed "$arg"`
    fi
    + eval `echo args$i`=\'"`echo "x$arg" | sed -e "s/^x//" -e "s,','\\\\\'',g"`"\'
    i=`expr $i + 1`
    done
    case $i in

There is a more elegant substitution in bash but since the script appears to be avoid such usage I changed it to the scary looking echo|sed
s="'\''"; # a quoted single quote
eval `echo args$i`="'$

{arg//\'/$s}

'"

My testcase in cygwin:

% groovy -e 'println System.getenv("""JAVA_HOME"""); println args[0]' '/bin/foo"'\'' "bar'
c:/Program Files/Java/jdk1.5.0_18
C:/cygwin/bin/foo"' "bar

This results in much safer argument munging than the current script uses. Personally I would go in and double-quote all the variable expansions that aren't quoted currently as well.

Show
Cold Dimsum added a comment - I am currently testing out this patch in my cygwin environment, so far so good: % diff -u startGroovy.DIST startGroovy — startGroovy.DIST 2009-07-07 22:40:47.140625000 -0500 +++ startGroovy 2009-07-07 23:53:42.828125000 -0500 @@ -218,10 +218,9 @@ for arg in "$@" ; do CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` if [ $CHECK -ne 0 ] ; then eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` else eval `echo args$i`="\"$arg\"" + arg=`cygpath --path --ignore --mixed "$arg"` fi + eval `echo args$i`=\'"`echo "x$arg" | sed -e "s/^x//" -e "s,','\\\\\'',g"`"\' i=`expr $i + 1` done case $i in There is a more elegant substitution in bash but since the script appears to be avoid such usage I changed it to the scary looking echo|sed s="'\''"; # a quoted single quote eval `echo args$i`="'$ {arg//\'/$s} '" My testcase in cygwin: % groovy -e 'println System.getenv("""JAVA_HOME"""); println args [0] ' '/bin/foo"'\'' "bar' c:/Program Files/Java/jdk1.5.0_18 C:/cygwin/bin/foo"' "bar This results in much safer argument munging than the current script uses. Personally I would go in and double-quote all the variable expansions that aren't quoted currently as well.
Hide
Permalink
Volker Börchers added a comment -

Could you please try my patch that is attached to https://jira.codehaus.org/browse/GROOVY-5878 if it fixes this issue too?

Show
Volker Börchers added a comment - Could you please try my patch that is attached to https://jira.codehaus.org/browse/GROOVY-5878 if it fixes this issue too?
Hide
Permalink
Pascal Schumacher added a comment -

I am not the original poster, but your patch for GROOVY-5878 also fixes this issue for me.

Show
Pascal Schumacher added a comment - I am not the original poster, but your patch for GROOVY-5878 also fixes this issue for me.
Hide
Permalink
Paul King added a comment -

As far as I can tell, fixed as part of GROOVY-5878

Show
Paul King added a comment - As far as I can tell, fixed as part of GROOVY-5878

People

  • Assignee:
    Paul King
    Reporter:
    Kyrill Alyoshin
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: