groovy

Allow negative first argument without parentheses

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.6-rc-1
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    0

Description

Here's a couple of simple tests to show the bug:

Here is unit test that fails to run.

class NegativeParameterWithNoParenthesis extends GroovyTestCase
{
  def foo(a, b) {}

    void testFooWithNegativeParameter()
    {
       foo(-1, 2)
    }


    void testFooWithNegativeParameterNoParenthesis()
    {
       foo -1, 2
    }
}

-------------------------------- second test --------------------------------------

class TestDSL {
 
  def orientation( double azimuth, double elevation ) {
    println("azimuth = " + azimuth + " elevation = " + elevation);
  }
 
  def static process(dsl) {
    def closure = (Closure)new GroovyShell().evaluate("{->" + dsl + "}");
    closure.delegate = new TestDSL();
    closure();
  }
 
}

here's the dsl file (which I named test.dsl):

orientation -45.0, 45.0

to run the test:

TestDSL.process(new File("test.dsl").text);

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul King added a comment -

add code tags

Show
Paul King added a comment - add code tags
Paul King made changes -
Field Original Value New Value
Description Here's a couple of simple tests to show the bug:

Here is unit test that fails to run.

class NegativeParameterWithNoParenthesis extends GroovyTestCase
{
  def foo(a, b) {}


  void testFooWithNegativeParameter()
  {
   foo(-1, 2)
  }


  void testFooWithNegativeParameterNoParenthesis()
  {
   foo -1, 2
  }
}

-------------------------------- second test --------------------------------------

class TestDSL {
 
  def orientation( double azimuth, double elevation ) {
    println("azimuth = " + azimuth + " elevation = " + elevation);
  }
 
  def static process(dsl) {
    def closure = (Closure)new GroovyShell().evaluate("{->" + dsl + "}");
    closure.delegate = new TestDSL();
    closure();
  }
 
}
 
here's the dsl file (which I named test.dsl):
 
orientation -45.0, 45.0
 
 to run the test:
 
      TestDSL.process(new File("test.dsl").text);

 Here's a couple of simple tests to show the bug:

Here is unit test that fails to run.

{code}
class NegativeParameterWithNoParenthesis extends GroovyTestCase
{
  def foo(a, b) {}

    void testFooWithNegativeParameter()
    {
       foo(-1, 2)
    }


    void testFooWithNegativeParameterNoParenthesis()
    {
       foo -1, 2
    }
}
{code}

-------------------------------- second test --------------------------------------

{code}
class TestDSL {
 
  def orientation( double azimuth, double elevation ) {
    println("azimuth = " + azimuth + " elevation = " + elevation);
  }
 
  def static process(dsl) {
    def closure = (Closure)new GroovyShell().evaluate("{->" + dsl + "}");
    closure.delegate = new TestDSL();
    closure();
  }
 
}
{code}
 
here's the dsl file (which I named test.dsl):

{code}
orientation -45.0, 45.0
{code}
 
to run the test:

{code}
TestDSL.process(new File("test.dsl").text);
{code}
Hide
Permalink
Paul King added a comment -

This could be argued as a bug or a "feature", i.e. it currently behaves as designed. Never-the-less, it is perhaps a worthwhile feature enhancement if we can work out the right way to tweak the grammar to cover this case without causing other adverse effects.

Show
Paul King added a comment - This could be argued as a bug or a "feature", i.e. it currently behaves as designed. Never-the-less, it is perhaps a worthwhile feature enhancement if we can work out the right way to tweak the grammar to cover this case without causing other adverse effects.
Hide
Permalink
Pascal Schumacher added a comment - - edited

After reading Paul's comment I changed the type from bug to improvement and changed the title to reflect this.

Show
Pascal Schumacher added a comment - - edited After reading Paul's comment I changed the type from bug to improvement and changed the title to reflect this.
Pascal Schumacher made changes -
Summary negative first argument without parentheses fails to run Allow negative first argument without parentheses
Issue Type Bug [ 1 ] Improvement [ 4 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Burns Boaz
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: