groovy

Implement workaround for JDK 1.4 String.replaceAll bug.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.6-rc-2, 1.5.8
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

There is a bug in JDK 1.4's String.replaceAll in which quoted (\Q..\E) patterns that contain a backslash are not matched correctly.

This should work, but does not in JDK 1.4 (JDK 1.5 is OK):

assert "axa".equals("a\\a".replaceAll("\\Q\\\\E", "x"))

The workaround is to have RegexUtils.quote not put backslashes inside the quote, but instead escape out of the quote and use a backslash to escape the backslash.

So this does work in JDK 1.4 (and JDK 1.5 too of course):

assert "axa".equals("a\\a".replaceAll("\\Q\\E\\\\\\Q\\E", "x"))

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. GROOVY-3285 Implement String.replace(CharSequence, CharSequence), a JDK 1.5 method, for backwards compatibility

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Hide
Permalink
Jim White added a comment -

The test case is:

assert 'a\\a'.replace('\\', 'x') == 'axa'

It is in groovy.StringTest.testReplace.

Show
Jim White added a comment - The test case is: assert 'a\\a'.replace('\\', 'x') == 'axa' It is in groovy.StringTest.testReplace .

People

  • Assignee:
    Jim White
    Reporter:
    Jim White
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: