groovy

groovy.xml.QName uses string interning of volatile data and the trim antipattern

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6-rc-1
  • Fix Version/s: 2.1.0-rc-1
  • Component/s: XML Processing
  • Labels:
    None
  • Number of attachments :
    0

Description

1. String interning is a bad idea in most cases. QName calls intern on constants (what is a no-op), namespace URIs, local parts and prefixes This can easily eat up VM memory in sever applications.

2. As long as QName is not a class that is responsible to clean up program input there should probably be no trim(). This holds even more since trim() will only clean up leading and trailing withespace bot neither non-URIc input nor input that does not conform to the NCName production.

3. Please consider to remove prefix and it's semantics from groovy.xml.QName. Prefixes in QName classes have a long history of pain

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. GROOVY-3268 Remove the prefix property and it's semantics from groovy.xml.QName

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul King added a comment -

It might pay to split out the 3rd bullet into a separate issue. I imagine the first two can be examined and dealt with quickly. The third is likely to take more time.

Show
Paul King added a comment - It might pay to split out the 3rd bullet into a separate issue. I imagine the first two can be examined and dealt with quickly. The third is likely to take more time.
Hide
Permalink
Alexander Veit added a comment -

Split out the 3rd bullet: http://jira.codehaus.org/browse/GROOVY-3268.

Show
Alexander Veit added a comment - Split out the 3rd bullet: http://jira.codehaus.org/browse/GROOVY-3268 .
Hide
Permalink
Paul King added a comment -

update description to reflect third item movement

Show
Paul King added a comment - update description to reflect third item movement
Hide
Permalink
Pascal Schumacher added a comment - - edited

created a pull requests for this issue, see https://github.com/groovy/groovy-core/pull/90

Show
Pascal Schumacher added a comment - - edited created a pull requests for this issue, see https://github.com/groovy/groovy-core/pull/90
Hide
Permalink
Paul King added a comment -

intern is removed - sorry about the delay - thanks all

Show
Paul King added a comment - intern is removed - sorry about the delay - thanks all

People

  • Assignee:
    Paul King
    Reporter:
    Alexander Veit
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: