groovy

Nested javac Ant task does not do property substitution on its attributes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6-beta-2
  • Fix Version/s: 1.6.4, 1.7-beta-1
  • Component/s: Ant integration
  • Labels:
    None
  • Number of attachments :
    2

Description

If using groovyc with an embedded javac it is no longer possible to use Ant property substitution on the javac attributes.

For example having a call to groovyc like this:

<groovyc destdir="build" srcdir="src">
<javac source="$

{javac.source}" target="${javac.target}" debug="${javac.debug}" encoding="UTF-8"/>
</groovyc>

will lead to this error:

[groovyc] javac: invalid source release: ${javac.source}

This works fine with Groovy 1.5.7

I have attached a simple test case with a build.xml file which loads an external build.properties and then attempts to compile a single Java file.
To test simply edit the build.properties file to point groovy.home at a relevant Groovy installation.
Pointing it a my 1.6 b2 fails but 1.5.7 works.

I wasn't sure how to turn this into a Junit test easily though.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. GROOVY-3450 Ant properties don't work within the source / target attributes on javac Ant task within groovyc task

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
blackdrag blackdrag added a comment -

I must say this sounds quite strange. the nested javac task is the normal javac as you know it from ant. We did not add something to the task Also when you say this works in 1.5.7... isn't it the same there? But I can reproduce the issue.

Show
blackdrag blackdrag added a comment - I must say this sounds quite strange. the nested javac task is the normal javac as you know it from ant. We did not add something to the task Also when you say this works in 1.5.7... isn't it the same there? But I can reproduce the issue.
Hide
Permalink
David Cate added a comment -

I arrived at the exact same problem inside my build but dumped out my environment properties. My IDE was presetting my ant.version and my java.version. Once i reset my properties, everything appears to work fine in 1.5.6 and above.

Show
David Cate added a comment - I arrived at the exact same problem inside my build but dumped out my environment properties. My IDE was presetting my ant.version and my java.version. Once i reset my properties, everything appears to work fine in 1.5.6 and above.
Hide
Permalink
Ryszard Perkowski added a comment -

This issue is also present in the 1.6.0 release.
The Groovyc task uses RuntimeConfigurable object for getting the javac attributes. Those attributes do not have project properties substituted. They are used to populate the Javac object with the proper values. So to fix that, we can either use the values from the Javac object or substitute the properties in the RuntimeConfigurable attributes map.

The suggested patch has been attached to this issue.

Show
Ryszard Perkowski added a comment - This issue is also present in the 1.6.0 release. The Groovyc task uses RuntimeConfigurable object for getting the javac attributes. Those attributes do not have project properties substituted. They are used to populate the Javac object with the proper values. So to fix that, we can either use the values from the Javac object or substitute the properties in the RuntimeConfigurable attributes map. The suggested patch has been attached to this issue.
Hide
Permalink
Paul King added a comment -

Thanks very much for the patch. Applied to 1_6 branch and trunk.

Show
Paul King added a comment - Thanks very much for the patch. Applied to 1_6 branch and trunk.

People

  • Assignee:
    Paul King
    Reporter:
    Steve Sowerby
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: