groovy

Cannot create instances of @Immutable classes that have single Map field

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6-beta-2
  • Fix Version/s: 1.6-rc-1, 1.7-beta-1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

The call new Foo([:]) below will lead to infinite recursion.

@Immutable final class Foo {
    Map bar
}
new Foo([:])

I guess the above code corresponds to

final class Foo {
    final Map bar
    Foo(Map bar) {
        this(['bar':bar])
    }
    Foo(HashMap args) {
       this.bar = args['bar'].asImmutable()
    }
}
new Foo([:])

It will never reach the termitating HashMap constructor.

Solution1: Generate only tuple-based ctor if single field. Do field initializations in this ctor.

Activity

Ascending order - Click to sort in descending order
Guillaume Laforge made changes -
Field Original Value New Value
Fix Version/s 1.7-beta-1 [ 14014 ]
Fix Version/s 1.6-rc-1 [ 14009 ]
Hide
Permalink
Tord Alenljung added a comment -

Workaround: call Map-based ctor (HashMap) explicity

new Foo((HashMap) [bar:[:]])
Show
Tord Alenljung added a comment - Workaround: call Map-based ctor (HashMap) explicity new Foo((HashMap) [bar:[:]])
Hide
Permalink
blackdrag blackdrag added a comment -

fixed

Show
blackdrag blackdrag added a comment - fixed
blackdrag blackdrag made changes -
Resolution Fixed [ 1 ]
Assignee Jochen Theodorou [ blackdrag ]
Status Open [ 1 ] Closed [ 6 ]
Hide
Permalink
Paul King added a comment -

Reopen until we handle HashMap case - seems close enough to original issue that I don't think it warrants another separate issue.

Show
Paul King added a comment - Reopen until we handle HashMap case - seems close enough to original issue that I don't think it warrants another separate issue.
Paul King made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Hide
Permalink
Paul King added a comment -

Added a solution for HashMap case. I haven't thought through the order in which initialisation vs special case handling should occur yet. Test still to come

Show
Paul King added a comment - Added a solution for HashMap case. I haven't thought through the order in which initialisation vs special case handling should occur yet. Test still to come
blackdrag blackdrag made changes -
Assignee Jochen Theodorou [ blackdrag ] Paul King [ paulk ]
Hide
Permalink
Paul King added a comment -

Should be fixed in trunk and 1.6-rc-1

Show
Paul King added a comment - Should be fixed in trunk and 1.6-rc-1
Paul King made changes -
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Paul King made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Paul King
    Reporter:
    Tord Alenljung
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: