groovy

groovysh does not run when CLASSPATH includes embeddable/groovy-all.jar

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.5.6
  • Fix Version/s: 1.6-rc-1, 1.5.8, 1.7-beta-1
  • Component/s: Groovysh
  • Labels:
    None
  • Environment:
    Mac OS X Leopard 10.5.5
  • Patch Submitted:
    Yes
  • Number of attachments :
    3

Description

groovysh does not run when CLASSPATH includes embeddable/groovy-all.jar. groovy, groovyc, and groovyConsole work fine.

$ echo $CLASSPATH

$ groovysh
Groovy Shell (1.5.6, JVM: 1.5.0_16-133)
Type 'help' or '\h' for help.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
groovy:000> \q

$ export CLASSPATH=$GROOVY_HOME/embeddable/groovy-all-1.5.6.jar

$ groovysh
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.codehaus.groovy.tools.GroovyStarter.rootLoader(GroovyStarter.java:101)
at org.codehaus.groovy.tools.GroovyStarter.main(GroovyStarter.java:130)
Caused by: org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'org.codehaus.groovy.tools.shell.util.HelpFormatter@d4f27' with class 'org.codehaus.groovy.tools.shell.util.HelpFormatter' to class 'org.apache.commons.cli.HelpFormatter'
at org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.castToType(DefaultTypeTransformation.java:340)
at groovy.lang.MetaClassImpl.setProperty(MetaClassImpl.java:1997)
at groovy.lang.MetaClassImpl.setProperty(MetaClassImpl.java:2591)
at groovy.lang.MetaClassImpl.setProperties(MetaClassImpl.java:1291)
at groovy.lang.MetaClassImpl.invokeConstructor(MetaClassImpl.java:1268)
at groovy.lang.MetaClassImpl.invokeConstructor(MetaClassImpl.java:1185)
at org.codehaus.groovy.runtime.InvokerHelper.invokeConstructorOf(InvokerHelper.java:809)
at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeNewN(ScriptBytecodeAdapter.java:230)
at org.codehaus.groovy.tools.shell.Main.main(Main.groovy:43)

  1. Text File
    3079Patch_v15X.txt
    21/Oct/08 4:26 AM
    1 kB
    Roshan Dawrani
  2. Text File
    3079Patch_v16X.txt
    21/Oct/08 3:27 AM
    1 kB
    Roshan Dawrani
  3. Text File
    3079Patch_v17X.txt
    21/Oct/08 6:11 AM
    1 kB
    Roshan Dawrani

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roshan Dawrani added a comment -

Hi,
Attaching a patch that is solving this issue.

The casting exception was coming in groovysh with groovy-all.jar on the classpath because the formatter created by org.codehaus.groovy.tools.shell.Main is of the type org.codehaus.groovy.tools.shell.util.HelpFormatter. This class extends org.apache.commons.cli.HelpFormatter but the JarJar step in groovy build, which creates embeddable JAR, changes it to groovyjarjarcommonscli.HelpFormatter.

This formatter gets passed to CliBuilder, which still uses the type org.apache.commons.cli.HelpFormatter as the JarJar step excludes CliBuilder to fix JIRA GROOVY-2295. Hence the type-mismatch and the casting exception.

The attached fix patch also excludes org.codehaus.groovy.tools.shell.util.HelpFormatter from JarJar bytecode modification, which makes the type used in this HelpFormatter and CliBuilder same.

rgds,
Roshan

Show
Roshan Dawrani added a comment - Hi, Attaching a patch that is solving this issue. The casting exception was coming in groovysh with groovy-all.jar on the classpath because the formatter created by org.codehaus.groovy.tools.shell.Main is of the type org.codehaus.groovy.tools.shell.util.HelpFormatter. This class extends org.apache.commons.cli.HelpFormatter but the JarJar step in groovy build, which creates embeddable JAR, changes it to groovyjarjarcommonscli.HelpFormatter. This formatter gets passed to CliBuilder, which still uses the type org.apache.commons.cli.HelpFormatter as the JarJar step excludes CliBuilder to fix JIRA GROOVY-2295 . Hence the type-mismatch and the casting exception. The attached fix patch also excludes org.codehaus.groovy.tools.shell.util.HelpFormatter from JarJar bytecode modification, which makes the type used in this HelpFormatter and CliBuilder same. rgds, Roshan
Hide
Permalink
Guillaume Laforge added a comment -

I guess it also affects 1.6 / 1.7?

Show
Guillaume Laforge added a comment - I guess it also affects 1.6 / 1.7?
Hide
Permalink
Roshan Dawrani added a comment -

Attaching the patch for branch 15X.

(sorry about separate attachments. Cannot attach a zip because of a local restriction. Will test for 17X branch and follow up with its patch, if required.)

Show
Roshan Dawrani added a comment - Attaching the patch for branch 15X. (sorry about separate attachments. Cannot attach a zip because of a local restriction. Will test for 17X branch and follow up with its patch, if required.)
Hide
Permalink
Roshan Dawrani added a comment -

Attaching the patch for version 1.7.x.

The issue was found in all 1.5.x, 1.6.x, and 1.7.x versions.

Show
Roshan Dawrani added a comment - Attaching the patch for version 1.7.x. The issue was found in all 1.5.x, 1.6.x, and 1.7.x versions.
Hide
Permalink
Roshan Dawrani added a comment -

Removed the jarjar step related mismatch for HelpFormatter to fix the issue.

Show
Roshan Dawrani added a comment - Removed the jarjar step related mismatch for HelpFormatter to fix the issue.

People

  • Assignee:
    Roshan Dawrani
    Reporter:
    The Brain
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: