groovy

fix private field visibility

Details

  • Type: Task Task
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: 3.0
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

this task collects all the issues related to a privae field being visible, when it should not be visible

Issue Links

is depended upon by

Sub-task - The sub-task of the issue GROOVY-3073 Private inheritance bug: Closure accessing private method

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Task - A task that needs to be done. GROOVY-2503 MOP 2.0 design inflluencing issues

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
is related to

Bug - A problem which impairs or prevents the functions of the product. GROOVY-3142 Unable to access inherited private fields from a closure within an inherited method

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
relates to

Sub-task - The sub-task of the issue GROOVY-2433 Closure in base class unable to call private methods when invoked from derived class

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
blackdrag blackdrag made changes -
Field Original Value New Value
Link This issue is depended upon by GROOVY-2503 [ GROOVY-2503 ]
blackdrag blackdrag made changes -
Link This issue is related to GROOVY-3142 [ GROOVY-3142 ]
Hide
Permalink
Michael Kebe added a comment -

I just read Neal Ford's book "The Productive Programmer". And in chapter 12 "Meta-Programming" he just picked this bug to show testing a private method of Java with Groovy. Here is a quote:

Technically, this is a bug in Groovy (that has been there since day one), but it's so insanely useful, no one has bothered to fix it. And I hope they never do. In any language with strong reflection capabilities, the private keyword is not much more than documentation anyway: I can always use reflection to get to it if the need arises.

Maybe there is a way to give the testing community an option to allow the access of private methods/fields in testcases?

Show
Michael Kebe added a comment - I just read Neal Ford's book "The Productive Programmer". And in chapter 12 "Meta-Programming" he just picked this bug to show testing a private method of Java with Groovy. Here is a quote: Technically, this is a bug in Groovy (that has been there since day one), but it's so insanely useful, no one has bothered to fix it. And I hope they never do. In any language with strong reflection capabilities, the private keyword is not much more than documentation anyway: I can always use reflection to get to it if the need arises. Maybe there is a way to give the testing community an option to allow the access of private methods/fields in testcases?
Hide
Permalink
Merlyn Albery-Speyer added a comment -

Maybe there is a way to give the testing community an option to allow the access of private methods/fields in testcases?

It'd be easy enough to provide a declarative-style way of suppressing access checks while executing a closure.

Personally, I think that the @ convention for bypassing access protection is in line with other features Groovy offers such as redefining the methods of other classes.

Show
Merlyn Albery-Speyer added a comment - Maybe there is a way to give the testing community an option to allow the access of private methods/fields in testcases? It'd be easy enough to provide a declarative-style way of suppressing access checks while executing a closure. Personally, I think that the @ convention for bypassing access protection is in line with other features Groovy offers such as redefining the methods of other classes.
Guillaume Laforge made changes -
Link This issue is depended upon by GROOVY-3073 [ GROOVY-3073 ]
Guillaume Laforge made changes -
Link This issue relates to GROOVY-2433 [ GROOVY-2433 ]
Hide
Permalink
Donal Murtagh added a comment -

I might be wrong but I thought @ was for accessing (from within a class) a private field 'foo' when the class also has a public property named 'foo', i.e. it provides a way to disambiguate between a private field and public property of the same name.

I disagree with the statement from Neal Ford's book. While this bug is useful if you only want to use Groovy to test or script Java apps, if you want to build robust production apps in Groovy, this bug makes it impossible to protect a class' invariants.

Show
Donal Murtagh added a comment - I might be wrong but I thought @ was for accessing (from within a class) a private field 'foo' when the class also has a public property named 'foo', i.e. it provides a way to disambiguate between a private field and public property of the same name. I disagree with the statement from Neal Ford's book. While this bug is useful if you only want to use Groovy to test or script Java apps, if you want to build robust production apps in Groovy, this bug makes it impossible to protect a class' invariants.
Hide
Permalink
Serg Lifinsky added a comment -

Example hoto implement private methods and properties in javasxript using wrap method

Show
Serg Lifinsky added a comment - Example hoto implement private methods and properties in javasxript using wrap method
Serg Lifinsky made changes -
Attachment privateInJsUseWrapMethodExample.js [ 62664 ]
Serg Lifinsky made changes -
Attachment privateInJsUseWrapMethodExample.js [ 62665 ]
Serg Lifinsky made changes -
Attachment privateInJsUseWrapMethodExample.js [ 62665 ]
Hide
Permalink
Paul King added a comment -

@Serg: your example is nice but how is it related to the issue in Groovy.

Show
Paul King added a comment - @Serg: your example is nice but how is it related to the issue in Groovy.
Hide
Permalink
Serg Lifinsky added a comment -

Using closure as wrap method in example and control call to private method. Only in wrapers for protected and public methods we set caller as current class, and in wrapper for private method validate that caller is current class

Show
Serg Lifinsky added a comment - Using closure as wrap method in example and control call to private method. Only in wrapers for protected and public methods we set caller as current class, and in wrapper for private method validate that caller is current class
Hide
Permalink
Serg Lifinsky added a comment -

If class already have private method which work with private property, do not generate default getter/setter for this private property. Hot fix

Show
Serg Lifinsky added a comment - If class already have private method which work with private property, do not generate default getter/setter for this private property. Hot fix

People

  • Assignee:
    Unassigned
    Reporter:
    blackdrag blackdrag
Vote (26)
Watch (28)

Dates

  • Created:
    Updated: