groovy

Please make toString on GPath XML nodes return value of text() and/or add getText() getter to node

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.5.5
  • Fix Version/s: None
  • Component/s: XML Processing
  • Labels:
    None
  • Number of attachments :
    0

Description

Guys, am I missing something - it's very painful when using XmlParser and trying to get the value text of nodes, having to call text() all the time and remember it is a method.

At the very least node.text (calling getText()) should work.

Even better, have toString() on the node return the text instead of something that looks like the output of dump()

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul King added a comment -

.text is reserved for Nodes which have sub nodes with that name.

I don't usually find it hard to remember. All Groovy "associative" type collections, e.g. SQL, XML, Maps require you to use methods.

Show
Paul King added a comment - .text is reserved for Nodes which have sub nodes with that name. I don't usually find it hard to remember. All Groovy " associative " type collections, e.g. SQL, XML, Maps require you to use methods.
Hide
Permalink
Paul King added a comment -

Just having a look at this issue again. The summary mentions GPath (XmlSlurper) while the description mentions XmlParser. The getText() suggestion isn't workable but altering toString() might be. However, before starting we need to clarify which API we are talking about.

Show
Paul King added a comment - Just having a look at this issue again. The summary mentions GPath ( XmlSlurper ) while the description mentions XmlParser . The getText() suggestion isn't workable but altering toString() might be. However, before starting we need to clarify which API we are talking about.
Hide
Permalink
Paul King added a comment -

Just checked. XmlSlurper already calls text() inside toString(). I guess we could make XmlParser do this too. There are 6 tests which would break because they rely on the existing toString() behavior. From a consistency point of view, I think the change would be good but we have to think how many end users tests also rely on the current toString() behavior.

Show
Paul King added a comment - Just checked. XmlSlurper already calls text() inside toString(). I guess we could make XmlParser do this too. There are 6 tests which would break because they rely on the existing toString() behavior. From a consistency point of view, I think the change would be good but we have to think how many end users tests also rely on the current toString() behavior.
Hide
Permalink
Christopher Paulicka added a comment -

I just started using XmlParser, and I was surprised when text() didn't show up in the toString() call.
After much thought, you can't really evaluate the oddness to new users versus consequences of change to current users, so I would lean towards "correctness" at that point, and make the change.

Show
Christopher Paulicka added a comment - I just started using XmlParser, and I was surprised when text() didn't show up in the toString() call. After much thought, you can't really evaluate the oddness to new users versus consequences of change to current users, so I would lean towards "correctness" at that point, and make the change.

People

  • Assignee:
    Unassigned
    Reporter:
    Marc Palmer
Vote (2)
Watch (2)

Dates

  • Created:
    Updated: