print [1, 2].collect { it + 1 } doesn't seem to parse properly

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: ast builder, parser
  • Labels:
    None

Description

Bing Ran spotted this...

1> print [1,2].collect{it + 1}
2> execute
null

while this works:

1> list = [1,2]
2> print list.collect{it + 1}
3> execute
[2, 3]

Issue Links

is depended upon by

Task - A task that needs to be done. GROOVY-753 complete parser

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Poirier added a comment -

The new expression parser should fix this. RSN.

Show
Chris Poirier added a comment - The new expression parser should fix this. RSN.
Hide
Permalink
Chris Poirier added a comment -

At present, this can't be fixed. The parser is unable to tell [1, 2] the list from [1, 2] the array dereference. As a result, you will need to include parenthesis on the print() in order to make this work.

I'm leaving the issue open for now. Hopefully, we can fix it later.

Show
Chris Poirier added a comment - At present, this can't be fixed. The parser is unable to tell [1, 2] the list from [1, 2] the array dereference. As a result, you will need to include parenthesis on the print() in order to make this work. I'm leaving the issue open for now. Hopefully, we can fix it later.
Hide
Permalink
Chris Poirier added a comment -

I would like to think that we can get this to work at run time with a type test and a branch. In some cases, it might even be possible to choose at compile time, once the symbol table for the statement's scope has been calculated. Thoughts?

Show
Chris Poirier added a comment - I would like to think that we can get this to work at run time with a type test and a branch. In some cases, it might even be possible to choose at compile time, once the symbol table for the statement's scope has been calculated. Thoughts?
Hide
Permalink
blackdrag blackdrag added a comment -

this is not really a class generation bug

Show
blackdrag blackdrag added a comment - this is not really a class generation bug
Hide
Permalink
Guillaume Laforge added a comment -

Optional parenthesis are allowed for top-level statements, not for such complex ones.

Show
Guillaume Laforge added a comment - Optional parenthesis are allowed for top-level statements, not for such complex ones.

People

  • Assignee:
    Guillaume Laforge
    Reporter:
    james strachan
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: