groovy
  1. groovy
  2. GROOVY-2756

create new user overwritable operator methods for <,==,>,<=,=>,<==>

    Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: groovy-runtime
    • Labels:
      None
    • Number of attachments :
      0

      Description

      as not everything we want to let <,==,>,<=,=>,<==> operate on is a total order, it would be nice to have one of these defined only. Also the current solution with Comparable seems to lead to many problems, because Comparable itself is thought to be used with an exact counter part, but we might want to let it work on other classes as well. for this we should go away from Comparable. I would suggest we write a single method with a bitfield containing flags for <,> and ==. Then the user can throw an exception if a flagged operation is not available, also he can implement only < (100) or > (010) or == (001) or <= (101) or =>(011) or <=> (111). the way to keep backwards compatibility with this would be to add a compareTo method that uses the bits 111.. Well needs more discussion

        Issue Links

          Activity

          Paul King made changes -
          Field Original Value New Value
          Link This issue is related to GROOVY-1765 [ GROOVY-1765 ]
          Paul King made changes -
          Link This issue depends upon GROOVY-2576 [ GROOVY-2576 ]
          Paul King made changes -
          Link This issue is related to GROOVY-2576 [ GROOVY-2576 ]
          Paul King made changes -
          Link This issue depends upon GROOVY-2576 [ GROOVY-2576 ]
          Paul King made changes -
          Link This issue relates to GROOVY-1889 [ GROOVY-1889 ]
          blackdrag blackdrag made changes -
          Assignee Jochen Theodorou [ blackdrag ]
          Hide
          Jörg Staudemeyer added a comment -

          What ever implementation (one or multiple methods) will be selected, comparison operator methods should be allowed to return arbitrary types, not only boolean (and certainly not only integer) results. Otherwise utilization in DSLs is too much restricted (as is the case with Groovy 1.x).
          See discussions at http://www.nabble.com/Overloading-comparison-operators-td18504388.html and http://www.nabble.com/operator-overloading-td12984525.html.

          Show
          Jörg Staudemeyer added a comment - What ever implementation (one or multiple methods) will be selected, comparison operator methods should be allowed to return arbitrary types, not only boolean (and certainly not only integer) results. Otherwise utilization in DSLs is too much restricted (as is the case with Groovy 1.x). See discussions at http://www.nabble.com/Overloading-comparison-operators-td18504388.html and http://www.nabble.com/operator-overloading-td12984525.html .
          blackdrag blackdrag made changes -
          Link This issue is depended upon by GROOVY-2503 [ GROOVY-2503 ]
          blackdrag blackdrag made changes -
          Component/s groovy-runtime [ 16250 ]

            People

            • Assignee:
              blackdrag blackdrag
              Reporter:
              blackdrag blackdrag
            • Votes:
              3 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: