groovy

changed behaviour of isImplicitThis() in MethodCallExpression

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6-beta-1
  • Fix Version/s: 1.5.6, 1.6-beta-1
  • Component/s: ast builder
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

The method isImplicitThis() in MethodCallExpression has changed its behaviour. At least after compilation phase SEMANTIC_ANALYSIS. After phase CONVERSION the behaviour would have been as expected.

Expected return values:

  • anObj.methodCall() isImplicitThis() returns false
  • this.println("anything") isImplicitThis() returns false
  • println("anything") isImplicitThis() returns true

Return values at the moment (Revision: 10884) :

  • anObj.methodCall() isImplicitThis() returns true
  • this.println("anything") isImplicitThis() returns true
  • println("anything) isImplicitThis() returns true

patches
------------
1. fix with Test

The patch depends (only test) on the patch attached to Jira issue: http://jira.codehaus.org/browse/GROOVY-2615
Sorry for this inconvenience

Issue Links

Activity

Hide
Martin Kempf added a comment -

Fixes the issue. But does not contain the tests

Show
Martin Kempf added a comment - Fixes the issue. But does not contain the tests
Hide
Martin Kempf added a comment -

Tests for this issue.
The tests depend on the provided test environment in GROOVY-259

Show
Martin Kempf added a comment - Tests for this issue. The tests depend on the provided test environment in GROOVY-259

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: