Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.5, 1.5.2, 1.5.4
-
Fix Version/s: 1.6-rc-1, 1.5.8, 1.7-beta-1
-
Component/s: None
-
Labels:None
-
Environment:Groovy 1.5.4
Spring 2.5
-
Testcase included:yes
-
Number of attachments :
Description
I suspect this is connected with GROOVY-2006, here is the case:
I have two Spring-loaded groovy scripts, marked with refresh-check-delay, which loads them as CGLIB proxies. Invoking a method on the proxy instance, I get
Exception in thread "main" java.lang.IllegalArgumentException: object is not an instance of declaring class
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:86)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:226)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:899)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:740)
at org.codehaus.groovy.runtime.InvokerHelper.invokePogoMethod(InvokerHelper.java:777)
at org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:757)
at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodN(ScriptBytecodeAdapter.java:167)
at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethod0(ScriptBytecodeAdapter.java:195)
at X.doIt(script1.groovy]:5)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:301)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:182)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:149)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.doProceed(DelegatingIntroductionInterceptor.java:131)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.invoke(DelegatingIntroductionInterceptor.java:119)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
at $Proxy1.doIt(Unknown Source)
at TestMe.main(TestMe.java:20)
script1.groovy
class X implements Doable {
def prop
void doIt() {
println prop.getClass().getName();
prop.doIt();
}
}
script2.groovy
class Y {
void doIt() { println "OK"; }
}
Doable.java
public interface Doable { void doIt(); }
spring.xml
<?xml version="1.0" encoding="UTF-8"?> <beans xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:lang="http://www.springframework.org/schema/lang" xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd http://www.springframework.org/schema/lang http://www.springframework.org/schema/lang/spring-lang-2.5.xsd"> <lang:groovy id="y" script-source="classpath:groovy/script2.groovy" refresh-check-delay="1000"/> <lang:groovy id="x" script-source="classpath:groovy/script1.groovy" refresh-check-delay="1000"> <lang:property name="prop" ref="y"/> </lang:groovy> </beans>
TestMe.java
import org.springframework.context.support.ClassPathXmlApplicationContext; public class TestMe { public static void main(String[] args) { ClassPathXmlApplicationContext ctxt = new ClassPathXmlApplicationContext("spring.xml"); Doable o = (Doable)ctxt.getBean("x"); o.doIt(); } }
Attachments
Activity
Hide
René de Bloois
added a comment -
Maybe my comment didn't come out right. I didn't mean to say that the problem is caused by the fact that the script implements the GroovyObject. It was just step 1 in the complete reasoning that the first paragraph represents.
In your case (the script refresh proxy) the problem would be solved if the groovy runtime was designed to call invokeMethod() on the groovy object proxy.
But there may be problems with this solution too. Other kinds of proxies do also exist. Some only add logic to specific method calls. For example, transaction management is added to all find*, get*, add*, update* methods. But if all method calls go through invokeMethod(), the transaction management will be circumvented. So we would lose the ability to select methods.
So I answered my own question from my previous comment 
Show
René de Bloois
added a comment - Maybe my comment didn't come out right. I didn't mean to say that the problem is caused by the fact that the script implements the GroovyObject. It was just step 1 in the complete reasoning that the first paragraph represents.
In your case (the script refresh proxy) the problem would be solved if the groovy runtime was designed to call invokeMethod() on the groovy object proxy.
But there may be problems with this solution too. Other kinds of proxies do also exist. Some only add logic to specific method calls. For example, transaction management is added to all find*, get*, add*, update* methods. But if all method calls go through invokeMethod(), the transaction management will be circumvented. So we would lose the ability to select methods.
So I answered my own question from my previous comment
add code tags