CST nodes created synthetically should always include some line number info

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.6-rc-2
  • Component/s: parser
  • Labels:
    None

Description

I wonder if there's a clean way we can fix the parser to do this automatically (e.g. setting the previous CST nodes line number info if the line numbers are -1

Issue Links

is depended upon by

Wish - General wishlist item GROOVY-259 unit test case to ensure that we always set line number information on all AST nodes

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Poirier added a comment -

I'm thinking, once the parser overhaul is complete, about changing the CST stuff, either by generating the ASTs directly (still thinking on that issue), or by making more use of the interpretation flag I added to Token. Until then, I'm going to leave things as they are.

Show
Chris Poirier added a comment - I'm thinking, once the parser overhaul is complete, about changing the CST stuff, either by generating the ASTs directly (still thinking on that issue), or by making more use of the interpretation flag I added to Token. Until then, I'm going to leave things as they are.
Hide
Permalink
james strachan added a comment -

cool - no rush or anything, this issue is just a reminder we should fix this somehow

Show
james strachan added a comment - cool - no rush or anything, this issue is just a reminder we should fix this somehow
Hide
Permalink
Guillaume Laforge added a comment -

Some more line numbering ticket

Show
Guillaume Laforge added a comment - Some more line numbering ticket

People

  • Assignee:
    blackdrag blackdrag
    Reporter:
    james strachan
Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: