groovy

sub-tabbedPane in swingbuilder missing title

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.5
  • Fix Version/s: 1.5.1
  • Component/s: Swing
  • Labels:
    None
  • Environment:
    JDK6u3, groovy1.5, winxp
  • Number of attachments :
    1

Description

I found that the sub-tabbedPane can not have a title, the test code is shown as follows:

import groovy.swing.*

def swing = new SwingBuilder()
def frame = swing.frame() {

    tabbedPane() {
        label(text:'a', title:'ta')
        tabbedPane() {
            label(text:'sa', title:'sta') // the title named sta does not show :(
            label(text:'sb', title:'stb') // the title named stb does not show, too :(
        }
    }
}

frame.pack()
frame.show()

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel.Sun added a comment - 
import groovy.swing.*

def swing = new SwingBuilder()
def frame = swing.frame() {

    tabbedPane() {
        label(text:'a', title:'ta')
        tabbedPane( title:'st') {  // the titile is not shown too, my god~
            label(text:'sa', title:'sta')
            label(text:'sb', title:'stb')
        }
    }
}

frame.pack()
frame.show()
Show
Daniel.Sun added a comment - import groovy.swing.* def swing = new SwingBuilder() def frame = swing.frame() { tabbedPane() { label(text:'a', title:'ta') tabbedPane( title:'st') { // the titile is not shown too, my god~ label(text:'sa', title:'sta') label(text:'sb', title:'stb') } } } frame.pack() frame.show()
Hide
Permalink
Jeff Brown added a comment -

The attached patch is not a real solution to the problem but may be a hint to what is really going wrong. I am not sure why the inspectChild method in TabbedPaneFactory is being called twice for each child, but it is. The second time inspectChild is called, the title attribute is not there. This patch simply ignores the second call for each child and that makes the symptom go away.

Why is inspectChild being called twice for each child?

Show
Jeff Brown added a comment - The attached patch is not a real solution to the problem but may be a hint to what is really going wrong. I am not sure why the inspectChild method in TabbedPaneFactory is being called twice for each child, but it is. The second time inspectChild is called, the title attribute is not there. This patch simply ignores the second call for each child and that makes the symptom go away. Why is inspectChild being called twice for each child?
Hide
Permalink
Danno Ferrin added a comment -

Ultimately inspectChild was being called for children that didn't belong to that tab. So now I am adding a bumper to insure that the particular closure instance is it is only called for children of that node, not for all such nodes.

Show
Danno Ferrin added a comment - Ultimately inspectChild was being called for children that didn't belong to that tab. So now I am adding a bumper to insure that the particular closure instance is it is only called for children of that node, not for all such nodes.

People

  • Assignee:
    Danno Ferrin
    Reporter:
    Daniel.Sun
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: