groovy

GroovyConsole - Undo/Redo don't set the dirty flag

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.1-rc-2
  • Fix Version/s: 1.1-rc-3
  • Component/s: Groovysh
  • Labels:
    None
  • Number of attachments :
    0

Description

The Undo and Redo actions don't set the dirty flag, though the script content is changed.

The fix is not trivial since the ConsoleTextEditor provides its unkown UndoAction and RedoAction, I am not sure what would be the prettiest way to solve this.
Using 'setDirty(true)' in the closure property of the 2 actions is not a solution since SwingBuilder's actions seem not to take into account the closure when an existing Action is provided.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Danno Ferrin added a comment -

Actually it's quite easy, I should listen to edit events rather than undoable changes. By default undoing and redoing doesn't create undoable change events. My fault for taking a shortcut really.

Show
Danno Ferrin added a comment - Actually it's quite easy, I should listen to edit events rather than undoable changes. By default undoing and redoing doesn't create undoable change events. My fault for taking a shortcut really.
Danno Ferrin made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Danno Ferrin made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Danno Ferrin made changes -
Assignee Danno Ferrin [ shemnon ]
Danno Ferrin made changes -
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Danno Ferrin made changes -
Fix Version/s 1.1 [ 13166 ]
Danno Ferrin made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Danno Ferrin
    Reporter:
    Olivier Armand
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: