groovy

add auto indent for GroovyConsole

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Incomplete
  • Affects Version/s: 1.1-rc-2
  • Fix Version/s: 1.6-rc-2
  • Component/s: Groovysh
  • Labels:
    None
  • Environment:
    Groovy1.1RC2, jdk6u3, winxp
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

I implemented auto indent for GroovyConsole.

The patch is attached and it is for Groovy1.1RC2

  1. Text File
    Console.groovy.patch
    03/Nov/07 5:41 AM
    4 kB
    Daniel.Sun
  1. autoindent.jpg
    35 kB
    03/Nov/07 5:56 AM

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel.Sun added a comment -

patch v2

Show
Daniel.Sun added a comment - patch v2
Hide
Permalink
Danno Ferrin added a comment -

This is too late in the RC cycle to make it in (by a couple of days), so I'm marking it as targeting 1.2.

I'll look into getting it into the SwingX Console demo as well.

Show
Danno Ferrin added a comment - This is too late in the RC cycle to make it in (by a couple of days), so I'm marking it as targeting 1.2. I'll look into getting it into the SwingX Console demo as well.
Hide
Permalink
Daniel.Sun added a comment -

Hi Danno,

It does not matter
I hope the improvement will be included in the first beta version of Groovy1.2.

Show
Daniel.Sun added a comment - Hi Danno, It does not matter I hope the improvement will be included in the first beta version of Groovy1.2.
Hide
Permalink
Danno Ferrin added a comment - - edited

While functional and desirable, I am concerned about the manner in which this patch is implemented. Currently all text editing functionality is local to the groovy.ui.text package, in mostly java classes. I feel that overloading it with groovy key listeners may comprimise future maintainability.

I would recommend that the implementation be placed in groovy.ui.text.TextEditor and implemented as Actions mapped via the InputMap and ActionMap, as is currently done for the soft-tab feature and indent/dedent features.

Also, there should be some sort of a kill-switch boolean to turn it off and on via a method. I don't know of anyone who wouldn't like auto-indent, but I am sure we will find someone at some point.

Show
Danno Ferrin added a comment - - edited While functional and desirable, I am concerned about the manner in which this patch is implemented. Currently all text editing functionality is local to the groovy.ui.text package, in mostly java classes. I feel that overloading it with groovy key listeners may comprimise future maintainability. I would recommend that the implementation be placed in groovy.ui.text.TextEditor and implemented as Actions mapped via the InputMap and ActionMap, as is currently done for the soft-tab feature and indent/dedent features. Also, there should be some sort of a kill-switch boolean to turn it off and on via a method. I don't know of anyone who wouldn't like auto-indent, but I am sure we will find someone at some point.

People

  • Assignee:
    Danno Ferrin
    Reporter:
    Daniel.Sun
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: