|
Thanks for the patch, Gabriele.
If you want to add some specific unit test demonstrating this, please feel free to do so. I reopen the issue cause it seems there's a regression in one of the tests of ConfigSlurperTest, in the test checking the serialization.
Gabriele, could you please have a second look at your patch, and the test cases, please? The suggested change was breaking some tests.
What shall we do with this issue? Ok guys, i didn't disappear. It's only that i have my real job to pursue and i'm really on a tight schedule.
Testing more closely the current behaviour of ConfigSlurper and the side effects the patch is causing, looks that it is so by design and not by mistake. This means that the patch i proposed looks to be changing the design in a way that would require to recode ConfigSlurper in a way that it's currently beyond my actual knowledge and beyond the time i have available to spend on it, so i think i have to give up. So what to say? The patch is not applicable, so disregard it and feel free to close the bug as WAD if you like. I wish to thank you for your kind attention anyway. We can keep this issue open till you find some more time to have a deeper look at the issue.
If you and Graeme think it's a desirable change to improve ConfigSlurper even more, then it's certainly worth waiting some more till we all have time to implement that feature properly. Thanks a lot Gabriele for your time and this patch. |
|||||||||||||||||||||||||||||||||||||||||||||||||
I'm attaching it as a file.