groovy

jUnit-4 Tests do not run

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.5.1
  • Component/s: None
  • Labels:
    None
  • Environment:
    Eclipse 3.3
  • Number of attachments :
    0

Description

There are multiple problems:

1. static imports are not supported :
import static org.junit.Assert.assertEquals throws an error in the editor

2. A NPE occurs in org.codehaus.groovy.eclipse.junit.launcher.JUnit4TestFinder.annotates(IMember):
String source = member.getSource().substring(0, charsToSearch);
Here are member.geSource() null. The reason seams to be that the member always is a BinaryType or BinaryMethod. Both hasn't a Source.

3. After fixing this with this and analyze the Tetsclass if there are @Test - Annotations the Testclass was executed. But the result was:
java.lang.Exception: No runnable methods
at org.junit.internal.runners.TestClassMethodsRunner.run(TestClassMethodsRunner.java:33)
at org.junit.internal.runners.TestClassRunner$1.runUnprotected(TestClassRunner.java:42)
at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
at org.junit.internal.runners.TestClassRunner.run(TestClassRunner.java:52)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:38)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brian Pontarelli added a comment -

This is actually a larger issue that I've finally tracked down. This occurs outside of Eclipse. It appears that groovyc is not actually compiling in any annotations. I'll open another issue to address this, but I would assume that this issue has been fixed in the latest trunk, but is still busted in RC1.

Show
Brian Pontarelli added a comment - This is actually a larger issue that I've finally tracked down. This occurs outside of Eclipse. It appears that groovyc is not actually compiling in any annotations. I'll open another issue to address this, but I would assume that this issue has been fixed in the latest trunk, but is still busted in RC1.
Hide
Permalink
Brian Pontarelli added a comment -

Ignore my last comment. I had a rogue 1.0 JAR in my path and just found it.

Show
Brian Pontarelli added a comment - Ignore my last comment. I had a rogue 1.0 JAR in my path and just found it.
Hide
Permalink
Aaron Tarter added a comment -

Thorsten,
Can you verify this happens on the 1.5 plugin at http://dist.codehaus.org/groovy/distributions/updateDev/? There is passing testcase with static imports, so at least (1) should work now.

Show
Aaron Tarter added a comment - Thorsten, Can you verify this happens on the 1.5 plugin at http://dist.codehaus.org/groovy/distributions/updateDev/? There is passing testcase with static imports, so at least (1) should work now.
Hide
Permalink
Thorsten Kamann added a comment -

Aaron,

the problem with statics are resolved. There is an additionally problem with static and the jdox library in the Maven Groovy-Plugin. But this is another story and unrelated to the eclipse-plugin.

But the execution of junit-tests isnt possible. Junit3 and jUnit4 test are not runnable

Show
Thorsten Kamann added a comment - Aaron, the problem with statics are resolved. There is an additionally problem with static and the jdox library in the Maven Groovy-Plugin. But this is another story and unrelated to the eclipse-plugin. But the execution of junit-tests isnt possible. Junit3 and jUnit4 test are not runnable
Hide
Permalink
Aaron Tarter added a comment -

I can run Junit-3 tests fine. In the example below the code compiles fine, but only the first test runs (uses junit3 test nomenclature). The Junit-4 testcase that is annotated with @Test, however, is not run by the Groovy Junit runner.

Show
Aaron Tarter added a comment - I can run Junit-3 tests fine. In the example below the code compiles fine, but only the first test runs (uses junit3 test nomenclature). The Junit-4 testcase that is annotated with @Test, however, is not run by the Groovy Junit runner.
Hide
Permalink
Aaron Tarter added a comment -

import static org.junit.Assert.assertEquals
import static org.junit.Assert.assertTrue
import org.junit.Test

class test extends GroovyTestCase {
void testSomething()

{ assertEquals("hello","hello") print "hello" }

@Test
void anoTest()

{ assertTrue(true) }

}

Show
Aaron Tarter added a comment - import static org.junit.Assert.assertEquals import static org.junit.Assert.assertTrue import org.junit.Test class test extends GroovyTestCase { void testSomething() { assertEquals("hello","hello") print "hello" } @Test void anoTest() { assertTrue(true) } }
Hide
Permalink
Aaron Tarter added a comment - - edited

I do see an NPE when the Junit runner is set to Junit4:

java.lang.NullPointerException
at org.codehaus.groovy.eclipse.junit.launcher.JUnit4TestFinder$Annotation.annotates(JUnit4TestFinder.java:84)
at org.codehaus.groovy.eclipse.junit.launcher.JUnit4TestFinder.isTest(JUnit4TestFinder.java:163)
at org.codehaus.groovy.eclipse.junit.launcher.SingleTypeTestSearchExtent.find(SingleTypeTestSearchExtent.java:31)
at org.codehaus.groovy.eclipse.junit.launcher.TestKind.search(TestKind.java:107)
at org.codehaus.groovy.eclipse.junit.launcher.TestKindRegistry.getTestTypes(TestKindRegistry.java:181)
at org.codehaus.groovy.eclipse.junit.launcher.JUnitBaseLaunchConfiguration.findTestTypes(JUnitBaseLaunchConfiguration.java:126)
at org.codehaus.groovy.eclipse.junit.launcher.JUnitBaseLaunchConfiguration.launch(JUnitBaseLaunchConfiguration.java:90)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:766)
at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:608)
at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:899)
at org.eclipse.debug.internal.ui.DebugUIPlugin$7.run(DebugUIPlugin.java:1102)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Show
Aaron Tarter added a comment - - edited I do see an NPE when the Junit runner is set to Junit4: java.lang.NullPointerException at org.codehaus.groovy.eclipse.junit.launcher.JUnit4TestFinder$Annotation.annotates(JUnit4TestFinder.java:84) at org.codehaus.groovy.eclipse.junit.launcher.JUnit4TestFinder.isTest(JUnit4TestFinder.java:163) at org.codehaus.groovy.eclipse.junit.launcher.SingleTypeTestSearchExtent.find(SingleTypeTestSearchExtent.java:31) at org.codehaus.groovy.eclipse.junit.launcher.TestKind.search(TestKind.java:107) at org.codehaus.groovy.eclipse.junit.launcher.TestKindRegistry.getTestTypes(TestKindRegistry.java:181) at org.codehaus.groovy.eclipse.junit.launcher.JUnitBaseLaunchConfiguration.findTestTypes(JUnitBaseLaunchConfiguration.java:126) at org.codehaus.groovy.eclipse.junit.launcher.JUnitBaseLaunchConfiguration.launch(JUnitBaseLaunchConfiguration.java:90) at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:766) at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:608) at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:899) at org.eclipse.debug.internal.ui.DebugUIPlugin$7.run(DebugUIPlugin.java:1102) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Hide
Permalink
Thorsten Kamann added a comment -

Aaron,

you are right with jUnit 3. But this only runs if you add manually a launch configiration for jUnit 3.
But I cannot use the "Run As...".

And you are right with the behaviour of the jUnit 4 Tests, too. I stepped through the code but I cannot understand why it happens. Perhaps it where a better solution to reuse the original jUnit-Runner and add a Run As contribution like in the TestNG-Plugin?

Show
Thorsten Kamann added a comment - Aaron, you are right with jUnit 3. But this only runs if you add manually a launch configiration for jUnit 3. But I cannot use the "Run As...". And you are right with the behaviour of the jUnit 4 Tests, too. I stepped through the code but I cannot understand why it happens. Perhaps it where a better solution to reuse the original jUnit-Runner and add a Run As contribution like in the TestNG-Plugin?
Hide
Permalink
Thorsten Kamann added a comment -

Now we can execute Groovy-based Unit3 and jUnit4 tests.

Show
Thorsten Kamann added a comment - Now we can execute Groovy-based Unit3 and jUnit4 tests.
Hide
Permalink
Paul King added a comment -

close off release 1.5.4

Show
Paul King added a comment - close off release 1.5.4

People

  • Assignee:
    Thorsten Kamann
    Reporter:
    Thorsten Kamann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: