eachFileRecurse crashes when descending a directory with circular symbolic links

Phil Walker added a comment - 07/Feb/08 10:41 AM The updated test script below fixes a problem with the previous isSymlink() method. When tested against groovy 1.5.3, the original problem disappears. The remaining requirement seems to be one of the following: 1. prevent eachFileRecurse from recursion below symbolic links to directories 2. provide a way to reject recursion, for example, by registering a callback filter that decides whether to recurse each directory The first approach is probably what is needed 99% of the time, the second is more flexible. #!/usr/bin/env groovy // setup the environment for this test by the following: // mkdir testdir // ln -s . testdir/parentdir infile = new File("testdir") infile.eachFileRecurse { printf("%s\n",it); if( isSymlink(it) ) { throw new IllegalArgumentException("circular symlinks"); } } // modified to reject false positives caused by symlinked parents def isSymlink(ff){ absfile = ff.getAbsoluteFile() parentDir = absfile.getParentFile() isLink = false if( parentDir ){ testfile = new File(parentDir.getCanonicalFile(),ff.getName()) ap = testfile.getAbsolutePath() cp = testfile.getCanonicalPath() aplower = ap.toLowerCase() cplower = cp.toLowerCase() isLink = (aplower != cplower) if( isLink ) { println() printf(" ff: %-20s\n",ff) printf(" absfile: %-20s\n",absfile) printf("parentDir:%-20s\n",parentDir) printf("testfile: %-20s\n",testfile) printf(" ap: %-20s\n",aplower) printf(" cp: %-20s\n",cplower) } } return isLink }

blackdrag blackdrag added a comment - 13/Oct/08 9:57 AM the code tries to recognize symlinks, it tries not to recognize if there is any circular reference. Following symlinks might be exactly what you want.