jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • groovy
  • GROOVY-1727 Groovy shell and Groovy swing console...
  • GROOVY-2061

Add Find/Replace actions to Console menu

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1-beta-3
  • Fix Version/s: 1.5
  • Component/s: Groovy Console
  • Labels:
    None

Description

The Console text editor has some find/replace functionality. Find ctrl+f, replace ctrl+h, find next F3, find previous shift-F3.

These need to be slightly re-written so that the actions can be added to the console menu. Also, they need to work when selected from the menu.

Also, the find functionality would be nice in the output area, so the menu should be sensitive to which area last had mouse focus (or only search output if the output is the permanent focus owner)

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    console_added_find_and_replace_to_menus_replace_fixed.patch
    18/Oct/07 8:36 PM
    3 kB
    Hamlet D'Arcy
  2. Text File
    console_added_find_and_replace_to_menus.patch
    18/Oct/07 8:04 PM
    3 kB
    Hamlet D'Arcy

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Hamlet D'Arcy added a comment - 18/Oct/07 8:04 PM

Added the following items to the Edit drop down menu of the Groovy Console:
Find... Ctrl+F - mnemonic is F
Find Next F3 - mnemonic is N
Find Previous Shift+F3 - mnemonic is V
Replace... Ctrl+H - mnemonic is E

I checked and none of the accelerators or mnemonics conflict with existing items.

Separator bars were added around the 4 to separate them from the rest of the menu.

This does not search the output area.

No changes were needed to FindReplaceUtility.java

I tested in Windows XP only.

The implementation of the findPrevious works, but there may be a cleaner way to do this.

I found two defects in the process, and this change did not introduce them: 1) if Find window is open when Frame is closed, the window remains open and the process doesn't die, and 2) Find previous does not match the first occurrence of the pattern if that pattern is at the start of the text area. I'll create separate defects for these.

Please let me know if anything else needs to change.

Show
Hamlet D'Arcy added a comment - 18/Oct/07 8:04 PM Added the following items to the Edit drop down menu of the Groovy Console: Find... Ctrl+F - mnemonic is F Find Next F3 - mnemonic is N Find Previous Shift+F3 - mnemonic is V Replace... Ctrl+H - mnemonic is E I checked and none of the accelerators or mnemonics conflict with existing items. Separator bars were added around the 4 to separate them from the rest of the menu. This does not search the output area. No changes were needed to FindReplaceUtility.java I tested in Windows XP only. The implementation of the findPrevious works, but there may be a cleaner way to do this. I found two defects in the process, and this change did not introduce them: 1) if Find window is open when Frame is closed, the window remains open and the process doesn't die, and 2) Find previous does not match the first occurrence of the pattern if that pattern is at the start of the text area. I'll create separate defects for these. Please let me know if anything else needs to change.
Hide
Permalink
Hamlet D'Arcy added a comment - 18/Oct/07 8:36 PM

I'm sorry... the Replace menu item was opening the find window. I added the (true) parameter to showDialog and it should work now. Sorry.

Show
Hamlet D'Arcy added a comment - 18/Oct/07 8:36 PM I'm sorry... the Replace menu item was opening the find window. I added the (true) parameter to showDialog and it should work now. Sorry.
Hide
Permalink
Danno Ferrin added a comment - 18/Oct/07 9:11 PM

Patch applied!

Thanks for the patch!

Show
Danno Ferrin added a comment - 18/Oct/07 9:11 PM Patch applied! Thanks for the patch!
Hide
Permalink
Claus Ibsen added a comment - 27/Jan/08 3:50 AM

Isn't this issue fixed? If so it could be closed.

Show
Claus Ibsen added a comment - 27/Jan/08 3:50 AM Isn't this issue fixed? If so it could be closed.

People

  • Assignee:
    Danno Ferrin
    Reporter:
    Danno Ferrin
Vote (0)
Watch (1)

Dates

  • Created:
    15/Aug/07 2:18 PM
    Updated:
    21/Dec/09 8:59 AM
    Resolved:
    21/Dec/09 8:59 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.