Issue Details (XML | Word | Printable)

Key: GROOVY-1966
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Guillaume Laforge
Reporter: Nic Grounds
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
groovy

FileNotFoundException (really IOExceptions in general) swallowed by XMLRPCServerProxy

Created: 02/Jul/07 02:26 PM   Updated: 03/Jul/07 03:37 AM
Component/s: XML-RPC
Affects Version/s: None
Fix Version/s: 1.1-beta-2

Time Tracking:
Not Specified

File Attachments: 1. Text File groovy-xmlrpc.patch (2 kB)


Patch Submitted: Yes


 Description  « Hide
The XMLRPCServerProxy class swallows IOExceptions in the invokeMethod method by throwing an XMLRPCCallFailureException (which by design have no caused by Throwable). This prevents users from being able to distinguish between generic IOExceptions and, for example, FileNotFoundExceptions.
The submitted patch fixes this by permitting XMLRPCCallFailureExceptions to have caused by Throwables/Exceptions and using this new Constructor in the invokeMethod method of XMLRPCServerProxy.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Guillaume Laforge added a comment - 02/Jul/07 02:29 PM
John, I'd like your advice on this.

John Wilson added a comment - 02/Jul/07 02:54 PM
The patch looks fine - please apply it.

John Wilson added a comment - 02/Jul/07 02:54 PM

Guillaume Laforge added a comment - 03/Jul/07 03:37 AM
Patch applied.
Thanks a lot.