[#GROOVY-1944] isCase implementation for BigDecimals needed based on numerical value only

groovy

Created: 16/Jun/07 03:27 AM Updated: 01/Jul/07 10:32 AM

Component/s:

groovy-jdk

Affects Version/s:

None

Fix Version/s:

1.1-beta-2

Time Tracking:

Not Specified

File Attachments:

GROOVY-1944.patch (2 kB)

Description

« Hide

BigDecimals carry both a numerical value and a precision (scale).

In Groovy, when BigDecimals are compared, only the numerical value is taken into account, but isCase() uses both value and scale.

This should be consistent.

assert 0.5 == 0.50000 // works
switch(0.5) {
case 0.50000: println "match" // doesn't match
}

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

It looks like a simple method in DefaultGroovyMethods.java is all that is needed:

public static boolean isCase(Number caseValue, Number switchValue) {
return NumberMath.compareTo(caseValue, switchValue)==0;
}

The attached patch contains this method and adds some tests to SwitchWithDifferentTypesTest.groovy.

[ Permalink | « Hide ]

applied