groovy

SwingBuilder / tableLayout -> more than two cells in one row are not displayed

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.1-beta-2
  • Component/s: None
  • Labels:
    None
  • Environment:
    Windows XP Professional sp2 JVM: 1.4.2_10-b03
  • Number of attachments :
    1

Description

In the attached example button 'B' is not visible.

Regards

Frank

-------

import groovy.swing.SwingBuilder

swing = new SwingBuilder()

frame = swing.frame() {
panel {
tableLayout {
tr {
td {button 'A'}
td {button 'B'}
td {button 'C'}
}
}
}
}
frame.pack()
frame.show()

Activity

Hide
Frank Harnack added a comment -

The attached patch seems to solve the problem.

Thanks to my colleague Alexej Stojanov. We fixed the issue together.

Regards

Frank

Show
Frank Harnack added a comment - The attached patch seems to solve the problem. Thanks to my colleague Alexej Stojanov. We fixed the issue together. Regards Frank
Hide
Paul King added a comment -

Jochen, let me know if you run out of time to apply this. I am happy to add it and do some testing. Just assign to me if you want, Paul.

Show
Paul King added a comment - Jochen, let me know if you run out of time to apply this. I am happy to add it and do some testing. Just assign to me if you want, Paul.
Hide
blackdrag blackdrag added a comment -

ok, you can apply the patch

Show
blackdrag blackdrag added a comment - ok, you can apply the patch
Hide
Paul King added a comment -

I applied the patch and it definitely fixed the first issue. It doesn't appear to work properly with colspan however, so I'll see if I can fix that too before committing.

Show
Paul King added a comment - I applied the patch and it definitely fixed the first issue. It doesn't appear to work properly with colspan however, so I'll see if I can fix that too before committing.
Hide
Paul King added a comment -

Patch applied plus I added some tweaks to the colspan calculating code (there wasn't any before) so it works (at least for the simple cases) too now.

Show
Paul King added a comment - Patch applied plus I added some tweaks to the colspan calculating code (there wasn't any before) so it works (at least for the simple cases) too now.
Hide
Paul King added a comment -

No further feedback, assuming fixed.

Show
Paul King added a comment - No further feedback, assuming fixed.
Hide
Frank Harnack added a comment -

Hi Paul,

thanks for your bugfix.

Unfortunately we decided not to use SwingBuilder for our little gui and we are to busy to test your additional modifications.
But we want to use SwingBuilder in the future (1.1-beta-2) to make our ant build scripts more user friendly.

Regards

Frank + Alexej

Show
Frank Harnack added a comment - Hi Paul, thanks for your bugfix. Unfortunately we decided not to use SwingBuilder for our little gui and we are to busy to test your additional modifications. But we want to use SwingBuilder in the future (1.1-beta-2) to make our ant build scripts more user friendly. Regards Frank + Alexej

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: