groovy

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: None
• Fix Version/s: 1.0-JSR-6
• Component/s: None
• Labels:

  None

AntBuilder instantiates task objects directly whereas Ant creates in a first time UnknownElement and RuntimeConfigurable to really create and configure the tasks when they are executed. Tasks may ask these classes to know how they have been configured what is not currently possible using the AntBuilder.

Proposed patch (not in unified diff format as my computer can't access cvs) removes all the instantiation logic to call the Handler Ant uses when it parses an xml file. This reduces drastically the complexity and ensures that the AntBuilder doesn't reinvent the wheel.

Provided unit tests compare the execution of the AntBuilder and the one of Ant to ensure that expectations are correct.

FileScanner is promoted to a real Ant task to make it better fit in the AntBuilder.

Patch fixes Issues 824 too (http://jira.codehaus.org/browse/GROOVY-824) (unit test included),

1. $i18n.getText("admin.common.words.hide")

   

   AntBuilderPatch.zip

   07/Jun/06 6:50 AM

   8 kB

   Marc Guillemot

   1. 
      SpoofTask.java 0.9 kB
   2. 
      SpoofTaskContainer.java 1 kB
   3. 
      AntBuilder.java 9 kB
   4. 
      AntTest.groovy 4 kB
   5. 
      AntTest.xml 0.6 kB
   6. 
      FileScanner.java 4 kB

   Download Zip

   $i18n.getText("admin.common.words.show")

   

   AntBuilderPatch.zip

   07/Jun/06 6:50 AM

   8 kB

   Marc Guillemot

• Assignee:

  Dierk Koenig

  Reporter:

  Marc Guillemot

• Created:

  07/Jun/06 6:50 AM

  Updated:

  07/Jun/06 7:50 AM

  Resolved:

  07/Jun/06 7:50 AM