groovy

Make maven pom Maven 2 friendly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

This patch will make the maven pom more friendly for Maven 2 users adding some hints for the m1 -> m2 converter

Issue Links

This issue is related to:
MEV-526 groovy:groovy-all inconsistent version for pom and jar Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Carlos Sanchez added a comment -

Related to GROOVY-1853

Show
Carlos Sanchez added a comment - Related to GROOVY-1853
Hide
Permalink
Russel Winder added a comment -

project.xml is no longer in the Groovy source, the Maven 1 build system has been deprecated and deleted.

The Groovy build system is currently Ant based. The Maven 2 POM at config/maven/groovy.pom controls the Ant Maven plugin, and all Maven repository related activities.

I think the attached patch is therefore redundant per se. However, if there is a change that needs making to the Maven 2 POMs used by the Ant build system then we should clearly deal with these.

Show
Russel Winder added a comment - project.xml is no longer in the Groovy source, the Maven 1 build system has been deprecated and deleted. The Groovy build system is currently Ant based. The Maven 2 POM at config/maven/groovy.pom controls the Ant Maven plugin, and all Maven repository related activities. I think the attached patch is therefore redundant per se. However, if there is a change that needs making to the Maven 2 POMs used by the Ant build system then we should clearly deal with these.
Hide
Permalink
Carlos Sanchez added a comment -

just remember to deploy to the codehaus maven2 repo using maven, so it goes to the right place (org.codehaus.groovy)

Show
Carlos Sanchez added a comment - just remember to deploy to the codehaus maven2 repo using maven, so it goes to the right place (org.codehaus.groovy)
Hide
Permalink
Russel Winder added a comment -

Our Ant build system uses the Ant Maven plugin. Is this not the right thing to do? Does deploying to the Maven repository require using a Maven 2 command instead?

Show
Russel Winder added a comment - Our Ant build system uses the Ant Maven plugin. Is this not the right thing to do? Does deploying to the Maven repository require using a Maven 2 command instead?
Hide
Permalink
Carlos Sanchez added a comment -

I'm not sure if it can be done from ant, so either you use maven 2 or you do it by hand, but in any case the files have to be in the right place not like last time.
Now you use org.codehaus.groovy groupId so the files need to be in a different place

Show
Carlos Sanchez added a comment - I'm not sure if it can be done from ant, so either you use maven 2 or you do it by hand, but in any case the files have to be in the right place not like last time. Now you use org.codehaus.groovy groupId so the files need to be in a different place
Hide
Permalink
blackdrag blackdrag added a comment -

maybe a description of how to do it at last with maven2 would help. I always thought we have no direct access to any maven repository, so I am not sure what "the right place" means to you.

Show
blackdrag blackdrag added a comment - maybe a description of how to do it at last with maven2 would help. I always thought we have no direct access to any maven repository, so I am not sure what "the right place" means to you.
Hide
Permalink
Carlos Sanchez added a comment -

ok, so right now you are deploying to the codehaus maven1 repo, which in turn is synced to maven1 central repo and converted to maven2
you are putting your releases in some place /groovy/. If you want to keep deploying with Maven 1 or manually now that you changed the pom groupId you need to consequently deploy the releases to /org.codehaus.groovy/

Codehaus also has a maven2 repo, to deploy with Maven 2 to that Maven 2 repo read
http://docs.codehaus.org/display/HAUSMATES/Maven+Guide

Show
Carlos Sanchez added a comment - ok, so right now you are deploying to the codehaus maven1 repo, which in turn is synced to maven1 central repo and converted to maven2 you are putting your releases in some place /groovy/. If you want to keep deploying with Maven 1 or manually now that you changed the pom groupId you need to consequently deploy the releases to /org.codehaus.groovy/ Codehaus also has a maven2 repo, to deploy with Maven 2 to that Maven 2 repo read http://docs.codehaus.org/display/HAUSMATES/Maven+Guide
Hide
Permalink
blackdrag blackdrag added a comment -

right now we are deploying to a project local directory. Afaik this directory is automatically synced with the maven1 repository. I guess we need to discuss that with Ben and Bob

Show
blackdrag blackdrag added a comment - right now we are deploying to a project local directory. Afaik this directory is automatically synced with the maven1 repository. I guess we need to discuss that with Ben and Bob
Hide
Permalink
Russel Winder added a comment -

We believe this issue is resolved in Subversion Head and the 1.1-beta releases. We will find out the real veracity of the claim when the final 1.1 release is made.

Show
Russel Winder added a comment - We believe this issue is resolved in Subversion Head and the 1.1-beta releases. We will find out the real veracity of the claim when the final 1.1 release is made.

People

Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.