groovy

use(category, closure) should return the closures return value.

Details

  • Type: Wish Wish
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-JSR-5, 1.0-JSR-6
  • Fix Version/s: 1.1-beta-1
  • Component/s: groovy-jdk
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

use(StringCategory) {
return "hello".capitalize()
}
returns null (use is a void method). However a closure call always returns Object. In keeping with the element of least surprise, use() should return the closures return value.

  1. Text File
    categoryReturnValuePatch.txt
    28/Feb/07 10:00 PM
    4 kB
    Jeff Brown
  2. File
    TestUseReturnValue.groovy
    03/Apr/06 3:19 PM
    0.5 kB
    Edward Povazan

Issue Links

is duplicated by

Improvement - An improvement or enhancement to an existing feature or task. GROOVY-1770 use(category){closure} should propagate the value returned by its closure

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. GROOVY-2474 Change all withXXX methods to return the value returned by their closure instead of void

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jeff Brown added a comment -

I have attached a patch including a simple test case.

Show
Jeff Brown added a comment - I have attached a patch including a simple test case.
Hide
Permalink
Jeff Brown added a comment -

To clarify my last comment... The patch that I attached (categoryReturnValuePatch.txt) includes not only a test case but the code change as well.

Show
Jeff Brown added a comment - To clarify my last comment... The patch that I attached (categoryReturnValuePatch.txt) includes not only a test case but the code change as well.
Hide
Permalink
Guillaume Laforge added a comment -

Jochen, could you have a look at this patch?

Show
Guillaume Laforge added a comment - Jochen, could you have a look at this patch?
Hide
Permalink
Paul King added a comment -

Should be fixed as result of fix to Groovy-1770 (basically a duplicate)

Show
Paul King added a comment - Should be fixed as result of fix to Groovy-1770 (basically a duplicate)

People

  • Assignee:
    blackdrag blackdrag
    Reporter:
    Edward Povazan
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: