groovy

align 2-arg 'each' methods on Maps and Lists and else; remove eachWithIndex

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Duplicate
  • Affects Version/s: 1.0-JSR-4
  • Fix Version/s: None
  • Component/s: groovy-jdk
  • Labels:
    None
  • Number of attachments :
    0

Description

Map.each reacts differently according to whether one or two args are passed into the closure.
The same approach can be taken for ease of use and consistency for Lists and else.

['a','b'].each

{println it}

['a','b'].each

{item, count -> println "$count: $item"}

eachWithIndex can be dropped then. (or at least be marked 'deprecated')

we need to go over all usage of eachWithIndex, e.g. in general 'object iteration methods', GPathResult, etc.

Issue Links

is duplicated by

Improvement - An improvement or enhancement to an existing feature or task. GROOVY-3797 Provide an index or counter for each/find/findAll/collect and friends by taking into accounts the arity of closures passed to them

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
relates to

Improvement - An improvement or enhancement to an existing feature or task. GROOVY-3797 Provide an index or counter for each/find/findAll/collect and friends by taking into accounts the arity of closures passed to them

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Hide
Permalink
John Wilson added a comment -

But eachWithIndex is defined on Maps and is quite useful:

m = [hello: "world"]
m.eachWithIndex

{x, i -> println x.key}

prints hello

I'd rather see

m.eachWithIndex

{k, v, i -> println v}

be implemented

Show
John Wilson added a comment - But eachWithIndex is defined on Maps and is quite useful: m = [hello: "world"] m.eachWithIndex {x, i -> println x.key} prints hello I'd rather see m.eachWithIndex {k, v, i -> println v} be implemented

People

  • Assignee:
    Unassigned
    Reporter:
    Dierk Koenig
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: