groovy

Constants defined in interface not visible to subclasses

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.0-JSR-4
  • Fix Version/s: 1.0-JSR-5
  • Component/s: bytecode
  • Labels:
    None
  • Number of attachments :
    0

Description

The latest release of Groovy does not recognise public static constants defined in an interface implemented by a super class. This worked in previous versions but is broken in the latest JSR release.

The problem occurs for me as I write XWork actions in Groovy. XWork has an Action interface which defines constants for the different response types (see http://www.opensymphony.com/xwork/api/com/opensymphony/xwork/Action.html)

This interface is implemented by ActionSupport (see http://www.opensymphony.com/xwork/api/com/opensymphony/xwork/ActionSupport.html). I have sub classed ActionSupport with my own class called "AbstractAction".

This is the class that is extended by my Groovy actions. However they throw errors like the below when loaded:

Caused by: script1133545392341.groovy: 29: The variable ERROR is undefined in the current scope
@ line 29, column 11.script1133545392341.groovy: 32: The variable SUCCESS is undefined in the current scope
@ line 32, column 10.

This does not make sense as these should clearly be visible given that the Groovy actions extend AbstractAction which extends ActionSupport which implements Action gasp!

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guillaume Laforge added a comment -

In the meantime (before we fix that), as a workaround, did you try prefixing the constants with "this", or better with the Action.ERROR, Action.SUCCESS?

Show
Guillaume Laforge added a comment - In the meantime (before we fix that), as a workaround, did you try prefixing the constants with "this", or better with the Action.ERROR, Action.SUCCESS?
Hide
Permalink
Graeme Rocher added a comment -

No I havnt tried either because:

a) I have loads of Actions implemented in Groovy this would take quite a while

and

b) As I said before its not addressing the problem is it?

I see this as quite a fundamental problem as there are probably many cases where this would come up.

Show
Graeme Rocher added a comment - No I havnt tried either because: a) I have loads of Actions implemented in Groovy this would take quite a while and b) As I said before its not addressing the problem is it? I see this as quite a fundamental problem as there are probably many cases where this would come up.
Hide
Permalink
blackdrag blackdrag added a comment -

the new scoping resolves this problem

Show
blackdrag blackdrag added a comment - the new scoping resolves this problem
Hide
Permalink
Behrang Saeedzadeh added a comment -

This is happening again for me:

public interface DateTimeFormatConstants {
    static final SimpleDateFormat AM_PM_TIME_FORMAT = new SimpleDateFormat("h:mma")

    static final SimpleDateFormat MILITARY_TIME_FORMAT = new SimpleDateFormat("HH:mm")
}

class DateTimeUtils implements DateTimeFormatConstants {
    static String convertMilitaryTimeToAmPm(String militaryTime) {
        Date date = MILITARY_TIME_FORMAT.parse(militaryTime)
        return AM_PM_TIME_FORMAT.format(date).toLowerCase()
    }
}
Show
Behrang Saeedzadeh added a comment - This is happening again for me: public interface DateTimeFormatConstants { static final SimpleDateFormat AM_PM_TIME_FORMAT = new SimpleDateFormat( "h:mma" ) static final SimpleDateFormat MILITARY_TIME_FORMAT = new SimpleDateFormat( "HH:mm" ) } class DateTimeUtils implements DateTimeFormatConstants { static String convertMilitaryTimeToAmPm( String militaryTime) { Date date = MILITARY_TIME_FORMAT.parse(militaryTime) return AM_PM_TIME_FORMAT.format(date).toLowerCase() } }
Hide
Permalink
Behrang Saeedzadeh added a comment -

And this is the error message I am getting:

You attempted to reference a variable in the binding or an instance variable from a static context.
You misspelled a classname or statically imported field. Please check the spelling.
You attempted to use a method 'AM_PM_TIME_FORMAT' but left out brackets in a place not allowed by the grammar.
 @ line 13, column 16.
           return AM_PM_TIME_FORMAT.format(date).toLowerCase()
                  ^
Show
Behrang Saeedzadeh added a comment - And this is the error message I am getting: You attempted to reference a variable in the binding or an instance variable from a static context. You misspelled a classname or statically imported field. Please check the spelling. You attempted to use a method 'AM_PM_TIME_FORMAT' but left out brackets in a place not allowed by the grammar. @ line 13, column 16. return AM_PM_TIME_FORMAT.format(date).toLowerCase() ^

People

  • Assignee:
    blackdrag blackdrag
    Reporter:
    Graeme Rocher
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: