Griffon
  1. Griffon
  2. GRIFFON-648

Handling files copied from griffon-app/conf/dist/bin

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.4.0
    • Component/s: build
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Properly handling duplicate files copied from griffon-app/conf/dist/bin and renamed them in case of using customize build scripts.

        Activity

        Hide
        Jocki Hendry added a comment - - edited

        In my project, folder griffon-app/conf/dist/zip/bin contains customized startApp.bat script that call javaw.exe instead of java.exe and refer to a splash image by using - splash argument. The current implementation will not overwrite duplicate files, so when I call griffon package zip, the custom startApp.bat will not override the built-in startApp.bat. In this case, I will prefer project files overwrite build-in files instead of renaming these files. The last version of Griffon will always override resource files when copying, this solve my issue

        Show
        Jocki Hendry added a comment - - edited In my project, folder griffon-app/conf/dist/zip/bin contains customized startApp.bat script that call javaw.exe instead of java.exe and refer to a splash image by using - splash argument. The current implementation will not overwrite duplicate files, so when I call griffon package zip , the custom startApp.bat will not override the built-in startApp.bat . In this case, I will prefer project files overwrite build-in files instead of renaming these files. The last version of Griffon will always override resource files when copying, this solve my issue
        Hide
        Andres Almiray added a comment -

        I noticed your blog entry and decided to apply the overwrite flag when copying resources (see https://github.com/griffon/griffon/commit/72b861f5ea88f6db4f08d407da306df47b184fc3 for reference). This should be fixed in Griffon 1.4.0. could you please verify that's the case? If so I can mar this issue as solved

        Show
        Andres Almiray added a comment - I noticed your blog entry and decided to apply the overwrite flag when copying resources (see https://github.com/griffon/griffon/commit/72b861f5ea88f6db4f08d407da306df47b184fc3 for reference). This should be fixed in Griffon 1.4.0. could you please verify that's the case? If so I can mar this issue as solved
        Hide
        Jocki Hendry added a comment -

        Yes, that is my expected solution for this issue. If original poster's use case is the same, I believe this issue can be closed and solved.

        Show
        Jocki Hendry added a comment - Yes, that is my expected solution for this issue. If original poster's use case is the same, I believe this issue can be closed and solved.
        Hide
        Ivan Arrizabalaga Getino added a comment -

        It's ok for me too.

        Show
        Ivan Arrizabalaga Getino added a comment - It's ok for me too.
        Hide
        Andres Almiray added a comment -

        Marked as solved in 1.4.0

        Show
        Andres Almiray added a comment - Marked as solved in 1.4.0

          People

          • Assignee:
            Andres Almiray
            Reporter:
            Ivan Arrizabalaga Getino
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: