Griffon
  1. Griffon
  2. GRIFFON-617

Installer plugin overwrites custom icons with griffon icon

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: plugins
    • Labels:
      None
    • Environment:
      Mac OS
    • Number of attachments :
      0

      Description

      Griffon 1.2.0
      Installer 0.7.0

      I placed the project specific icns file under griffon-app/resources/projectname.icns,
      upon "create-mac" a file of this name is created under
      .griffon<.....>/installer/mac/dist,

      but: it's the original griffon.icns - plus: griffon.icns is ALSO copied there.

      The project-specific icns-file is overwritten with a griffon.icns file!

      I re-installed the installer-plugin - no difference.
      I tried griffon package jar - and the jar contains the correct icon!
      I tried prepare- / create-izpack - contains the wrong icons (griffon.icns)
      thx

        Activity

        Hide
        Andres Almiray added a comment -

        Based on _GriffonPackage.groovy lines 781-795

        https://github.com/griffon/griffon/blob/master/subprojects/griffon-scripts/src/main/groovy/_GriffonPackage.groovy

        The file must be placed in griffon-app/conf/dist/shared in order to be picked up automatically. You may also define a value of application.icon in BuildConfig.groovy specifying a different location.

        Show
        Andres Almiray added a comment - Based on _GriffonPackage.groovy lines 781-795 https://github.com/griffon/griffon/blob/master/subprojects/griffon-scripts/src/main/groovy/_GriffonPackage.groovy The file must be placed in griffon-app/conf/dist/shared in order to be picked up automatically. You may also define a value of application.icon in BuildConfig.groovy specifying a different location.
        Hide
        Andres Almiray added a comment -

        We're missing a document section on the guide regarding this topic. I'll see that it gets added. Thank you for spotting it.

        Show
        Andres Almiray added a comment - We're missing a document section on the guide regarding this topic. I'll see that it gets added. Thank you for spotting it.
        Hide
        Gernot Starke added a comment -

        thank YOU for helping me out on this...
        regards
        Gernot

        Show
        Gernot Starke added a comment - thank YOU for helping me out on this... regards Gernot

          People

          • Assignee:
            Andres Almiray
            Reporter:
            Gernot Starke
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: