Griffon
  1. Griffon
  2. GRIFFON-544

UberBuilder does not use resolveFactory

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.0.2, 1.1.0
    • Component/s: builders
    • Labels:
      None
    • Number of attachments :
      0

      Description

      When the UberBuilder is asked to resolve a Factory it searches the child builders factories field. Instead it should call resolveFactory on the child builder.

      The reason is that some builders hide factories inside the parent factory and have the builder check this in the builder's resolveFactory method. Two examples are JMXBuilder and 0.3 groovyfx builds. This is actually critical for JavaFX support since the animation DSL is implemented in this fashion.

        Activity

        Hide
        Andres Almiray added a comment -

        Is there anything else to be done for this issue beyond what's found at https://github.com/griffon/griffon/commit/f62497ce31559d99b6584136734ad6d2bbac84a9 ?

        Show
        Andres Almiray added a comment - Is there anything else to be done for this issue beyond what's found at https://github.com/griffon/griffon/commit/f62497ce31559d99b6584136734ad6d2bbac84a9 ?

          People

          • Assignee:
            Danno Ferrin
            Reporter:
            Danno Ferrin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: