Griffon
  1. Griffon
  2. GRIFFON-520

Allow developer specific buildtime configuration to be defined

    Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: cli
    • Labels:
      None
    • Number of attachments :
      0

      Description

      As of 1.0.0 there are two locations where buildtime configuration can be placed

      $USER_HOME/.griffon/settings.groovy
      griffon-app/conf/BuildConfig.groovy
      

      The first is distribution wide (affects all projects) while the second is project specific. The first is never checked into SCM but the second may be. So where exactly should a developer put configuration that only affects him/her and not the rest of the team?

        Activity

        Hide
        Andres Almiray added a comment -

        Current proposal is to follow a similar convention as the one found in Gradle, that is, use the global file (settings.groovy) but specify a special variable naming convention or a code block that identifies unequivocally what variables should be applied to a particular project.

        Here's one example, given 2 projects whose names are sample and custom-app

        projects {
           sample {
               griffon.cli.verbose = true
           }
           'custom-app' {
              griffon.'default'.artifact.repository = 'my-local'
           }
        }
        
        Show
        Andres Almiray added a comment - Current proposal is to follow a similar convention as the one found in Gradle, that is, use the global file (settings.groovy) but specify a special variable naming convention or a code block that identifies unequivocally what variables should be applied to a particular project. Here's one example, given 2 projects whose names are sample and custom-app projects { sample { griffon.cli.verbose = true } 'custom-app' { griffon.' default '.artifact.repository = 'my-local' } }
        Hide
        Dean Iverson added a comment -

        I like it! Simple, straightforward to use, consistent with established convention.

        Show
        Dean Iverson added a comment - I like it! Simple, straightforward to use, consistent with established convention.
        Show
        Andres Almiray added a comment - Fixed with https://github.com/griffon/griffon/commit/e9848c22d2d6e88e9d5c89e035e4bff26e2ef481
        Hide
        Andres Almiray added a comment -

        Reopening as 1.1.0 includes a much better solution

        Show
        Andres Almiray added a comment - Reopening as 1.1.0 includes a much better solution

          People

          • Assignee:
            Andres Almiray
            Reporter:
            Andres Almiray
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: