Griffon
  1. Griffon
  2. GRIFFON-484

Griffon 0.9.5-rc2 does dependency resolution of plugins programatically which fails during compilation for plugins with incorrect dependency syntax

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.5-rc2
    • Fix Version/s: 0.9.5
    • Component/s: build
    • Labels:
      None
    • Number of attachments :
      0

      Description

      0.9.5-rc2 unlike 0.9.4 does dependency resolution via ArtifactInstallEngine.groovy pre-compilation even during non-compilation commands i.e. "clean". If a particular plugin has dependencies that are not supported by the specified maven repo or the dependency version/artifact/release id is incorrect the compilation will fail.

      In previous versions of Griffon this did not occur even if the dependency resolution of a plugin failed.

        Activity

        Hide
        Bisrat Dinka added a comment -

        When mentioning maven meant to write "the specified maven repo or the dependency group/artifact/version id is incorrect the compilation will fail" instead of "the specified maven repo or the dependency version/artifact/release id is incorrect the compilation will fail".

        Show
        Bisrat Dinka added a comment - When mentioning maven meant to write "the specified maven repo or the dependency group/artifact/version id is incorrect the compilation will fail" instead of "the specified maven repo or the dependency version/artifact/release id is incorrect the compilation will fail".
        Hide
        Andres Almiray added a comment -

        I'd say this is not really a bug but a stricter restriction given that you will get faster feedback if something is not configured in the right way. However, there are commands that are automatically excluded from running dependency resolution as a precondition. This setting is not open to other commands.

        Opening the door for configuration may help developers to pin point certain problems.

        Show
        Andres Almiray added a comment - I'd say this is not really a bug but a stricter restriction given that you will get faster feedback if something is not configured in the right way. However, there are commands that are automatically excluded from running dependency resolution as a precondition. This setting is not open to other commands. Opening the door for configuration may help developers to pin point certain problems.
        Hide
        Andres Almiray added a comment -

        To exclude a command from running dependency resolution add the following configuration flag to BuildConfig.groovy

        griffon.dependency.resolution.command.exclusions = ['Clean']
        

        The previous example skips dependency resolution for the 'Clean' script. Values in the list must be script names, not command targets, that is, if you want to exclude dependency resolution for install-plugin (not recommended!!) then configure as follows

        griffon.dependency.resolution.command.exclusions = ['InstallPlugin']
        
        Show
        Andres Almiray added a comment - To exclude a command from running dependency resolution add the following configuration flag to BuildConfig.groovy griffon.dependency.resolution.command.exclusions = ['Clean'] The previous example skips dependency resolution for the 'Clean' script. Values in the list must be script names, not command targets, that is, if you want to exclude dependency resolution for install-plugin ( not recommended!! ) then configure as follows griffon.dependency.resolution.command.exclusions = ['InstallPlugin']
        Show
        Andres Almiray added a comment - Fixed with https://github.com/griffon/griffon/commit/79e3b417a2a1abe85eaac6b1de6c06430126012a

          People

          • Assignee:
            Andres Almiray
            Reporter:
            Bisrat Dinka
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: