Griffon

griffon run-app asks to choose between RunApp and RunApplet

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 0.9.1
  • Fix Version/s: 0.9.2-beta-3, 1.2.0
  • Component/s: None
  • Labels:
    None
  • Environment:
    Ubuntu 10.04 amd64, using griffon 0.9.1
  • Number of attachments :
    0

Description

Using command line griffon run-app. The choose between RunApp and RunApplet is always proposed.
Is there no way to directly execute RunApp target?

Quoting this blog post (http://www.jroller.com/aalmiray/entry/griffon_0_9_sneak_peek) is should be feasible that's why I think it may be a bug:
It's worth mentioning that if you write out the full name of a target then it will work as before, even if there is multiple potential matches. This means that typing griffon run-app will invoke the RunApp script and will not give you a choice between RunApp and RunApplet.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andres Almiray added a comment -

Can't reproduce in latest trunk. Typing griffon run-app results in the expected behavior (running the app in standalone mode). However using rA still gives you a choice given that the script name is ambiguos

$ griffon rA
Welcome to Griffon 0.9.1 - http://griffon.codehaus.org/
Licensed under Apache Standard License 2.0
Griffon home is set to: /usr/local/griffon

Base Directory: /private/tmp/foo
Resolving dependencies...
Dependencies resolved in 515ms.
Multiple options please select:
[1] /usr/local/griffon/scripts/ReplaceArtifact.groovy
[2] /usr/local/griffon/scripts/RunApp.groovy
[3] /usr/local/griffon/scripts/RunApplet.groovy
Enter # [1,2,3]

Alternatives to running the application in standalone mode ar

griffon app
griffon a
Show
Andres Almiray added a comment - Can't reproduce in latest trunk. Typing griffon run-app results in the expected behavior (running the app in standalone mode). However using rA still gives you a choice given that the script name is ambiguos $ griffon rA Welcome to Griffon 0.9.1 - http: //griffon.codehaus.org/ Licensed under Apache Standard License 2.0 Griffon home is set to: /usr/local/griffon Base Directory: / private /tmp/foo Resolving dependencies... Dependencies resolved in 515ms. Multiple options please select: [1] /usr/local/griffon/scripts/ReplaceArtifact.groovy [2] /usr/local/griffon/scripts/RunApp.groovy [3] /usr/local/griffon/scripts/RunApplet.groovy Enter # [1,2,3] Alternatives to running the application in standalone mode ar griffon app griffon a
Hide
Permalink
Philippe Weber added a comment -

Thanks for the alternative.
But I retested with latest version from git and still have a choice when using run-app. To be sure I used --non-interactive and got
More than one script with the given name is available - cannot continue in non-interactive mode.

Show
Philippe Weber added a comment - Thanks for the alternative. But I retested with latest version from git and still have a choice when using run-app. To be sure I used --non-interactive and got More than one script with the given name is available - cannot continue in non-interactive mode.
Hide
Permalink
Andres Almiray added a comment -

Ok. Did you try the GRIFFON_0.9.X branch or master? The former is ahead of the latter at this point in time.

Show
Andres Almiray added a comment - Ok. Did you try the GRIFFON_0.9.X branch or master? The former is ahead of the latter at this point in time.
Hide
Permalink
Philippe Weber added a comment - - edited

As I'm rather new to Git previous test was with the master branch (from the INSTALL),
so I did git checkout -b remotes/origin/GRIFFON_0.9.X but the problem remains...

I dig in GriffonScriptRunner.java, and effectively you are using a search for an exact match in the script name, so run-app should match exactly RunApp script. However it seems the allScripts list is not sorted, is it?
So what happens if RunApplet occurs before RunApp in allScripts list ? Both would be in potentialScripts list, no ?
I add a sysout inside addCommandScripts to see in which order the scripts where loaded in allScripts list and here is what I got:

CreateScript.groovy
RunApplet.groovy
ClearProxy_.groovy
RunApp.groovy
PackageAddon.groovy

Hoping I understood all this correctly

Show
Philippe Weber added a comment - - edited As I'm rather new to Git previous test was with the master branch (from the INSTALL), so I did git checkout -b remotes/origin/GRIFFON_0.9.X but the problem remains... I dig in GriffonScriptRunner.java, and effectively you are using a search for an exact match in the script name, so run-app should match exactly RunApp script. However it seems the allScripts list is not sorted, is it? So what happens if RunApplet occurs before RunApp in allScripts list ? Both would be in potentialScripts list, no ? I add a sysout inside addCommandScripts to see in which order the scripts where loaded in allScripts list and here is what I got: CreateScript.groovy RunApplet.groovy ClearProxy_.groovy RunApp.groovy PackageAddon.groovy Hoping I understood all this correctly
Hide
Permalink
Andres Almiray added a comment -

Right. Sorting the list plus adding a second check for an exact match did the trick.

Show
Andres Almiray added a comment - Right. Sorting the list plus adding a second check for an exact match did the trick.
Hide
Permalink
Andres Almiray added a comment -

Griffon 0.9.5 re-introduced the problem on Linux as the sort() invocation was inadvertently removed.

Show
Andres Almiray added a comment - Griffon 0.9.5 re-introduced the problem on Linux as the sort() invocation was inadvertently removed.
Hide
Permalink
Andres Almiray added a comment -

Fixed with https://github.com/griffon/griffon/commit/ea1566275121219029bd5c918162be3f6155ca91

Show
Andres Almiray added a comment - Fixed with https://github.com/griffon/griffon/commit/ea1566275121219029bd5c918162be3f6155ca91

People

  • Assignee:
    Andres Almiray
    Reporter:
    Philippe Weber
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: