Griffon

Griffon upgrade removes quotes around application name in mvc group in Application.groovy, bringing back GRIFFON-14

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 0.3-BETA-2
  • Fix Version/s: 0.3
  • Component/s: cli
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

Create a fresh empty directory, install a copy of 0.2.1 and a copy of 0.3-BETA-2 in there and run the attached script to reproduce this.

Here is an execution log of this script on my machine:

[marcpa@mpaquett-person griffon-upgrade-bug]$ ls
griffon-0.2.1			griffon-0.3-BETA-2		griffon-bug-upgrade-repro.sh
[marcpa@mpaquett-person griffon-upgrade-bug]$ sh griffon-bug-upgrade-repro.sh
Creating foo-bar app with griffon 0.2.1 : notice single quotes when creating mvc-group in Application.groovy
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
Welcome to Griffon 0.2.1 - http://griffon.codehaus.org/
Licensed under Apache Standard License 2.0
Griffon home is set to: /Users/marcpa/griffon-upgrade-bug/griffon-0.2.1

Base Directory: /Users/marcpa/griffon-upgrade-bug
Running script /Users/marcpa/griffon-upgrade-bug/griffon-0.2.1/scripts/CreateApp_.groovy
Environment set to development
Warning, target causing name overwriting of name default
Warning, target causing name overwriting of name default
Warning, target causing name overwriting of name default
Warning, target causing name overwriting of name default
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/conf
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/conf/keys
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/conf/webstart
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/controllers
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/i18n
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/lifecycle
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/models
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/resources
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/views
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/lib
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/scripts
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/src
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/src/main
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/test
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/test/integration
    [mkdir] Created dir: /Users/marcpa/griffon-upgrade-bug/foo-bar/test/unit
[propertyfile] Creating new property file: /Users/marcpa/griffon-upgrade-bug/foo-bar/application.properties
     [copy] Copying 1 resource to /Users/marcpa/griffon-upgrade-bug/foo-bar
    [unjar] Expanding: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-shared-files.jar into /Users/marcpa/griffon-upgrade-bug/foo-bar
   [delete] Deleting: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-shared-files.jar
     [copy] Copying 1 resource to /Users/marcpa/griffon-upgrade-bug/foo-bar
    [unjar] Expanding: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app-files.jar into /Users/marcpa/griffon-upgrade-bug/foo-bar
   [delete] Deleting: /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app-files.jar
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
    [touch] Creating /Users/marcpa/griffon-upgrade-bug/foo-bar/griffon-app/i18n/messages.properties
Created Model for FooBar
Created View for FooBar
Created Controller for FooBar
Created IntegrationTests for FooBar

[propertyfile] Updating property file: /Users/marcpa/griffon-upgrade-bug/foo-bar/application.properties
Created Griffon Application at /Users/marcpa/griffon-upgrade-bug/foo-bar
startupGroups = ['foo-bar']
// MVC Group for "foo-bar"
'foo-bar' {
Upgrading with griffon 0.3-BETA-2 : notice no quotes around foo-bar in Application.groovy
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

Welcome to Griffon 0.3-BETA-2 - http://griffon.codehaus.org/
Licensed under Apache Standard License 2.0
Griffon home is set to: /Users/marcpa/griffon-upgrade-bug/griffon-0.3-BETA-2

Base Directory: /Users/marcpa/griffon-upgrade-bug/foo-bar
Running script /Users/marcpa/griffon-upgrade-bug/griffon-0.3-BETA-2/scripts/Upgrade.groovy
Environment set to development
NOTE: Your application currently expects griffon version [0.2.1], this target will upgrade it to Griffon 0.3-BETA-2 ...
   [delete] Deleting directory /Users/marcpa/.griffon/0.3-BETA-2/projects/foo-bar/resources
Updating application.properties ...
     [copy] Copying 1 resource to /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade
    [unjar] Expanding: /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade/griffon-shared-files.jar into /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade
   [delete] Deleting: /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade/griffon-shared-files.jar
     [copy] Copying 5 files to /Users/marcpa/griffon-upgrade-bug/foo-bar
   [delete] Deleting directory /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
     [move] Moving 1 file to /Users/marcpa/griffon-upgrade-bug/foo-bar
[propertyfile] Updating property file: /Users/marcpa/griffon-upgrade-bug/foo-bar/application.properties
     [copy] Copying 1 resource to /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade
    [unjar] Expanding: /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade/griffon-app-files.jar into /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade
   [delete] Deleting: /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade/griffon-app-files.jar
     [copy] Copying 16 files to /Users/marcpa/griffon-upgrade-bug/foo-bar
   [delete] Deleting directory /Users/marcpa/griffon-upgrade-bug/foo-bar/tmp-upgrade
Project upgraded
	startupGroups=["foo-bar"]
	foo-bar {
[marcpa@mpaquett-person griffon-upgrade-bug]$

Activity

There are no comments yet on this issue.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: