Inner classes created in Groovy cause compile errors when referenced from Java

IntelliJ IDEA has the same problem. See http://youtrack.jetbrains.net/issue/IDEA-50708

I open the following jira with the groovy project:

http://jira.codehaus.org/browse/GROOVY-4649

the related issue GROOVY-4649 is now closed

we'll pick up the fix when we move to 1.7.9

I was hoping that this was fixed after the upgrade to 1.7.10. But, this is only kind of working now from inside Eclipse. When I use the code above exactly, I get this compile problem:

The constructor Outer.Inner() is undefined	Client.java	/GroovyTest/src/foo	line 4	Java Problem

The problem goes away when I add an explicit constructor to the inner class:

class Outer {
  static class Inner {
    Inner() {}
  }
}

I get the same behavior for both 1.7.10 and 1.8.0.

However, when I compile the original code from the command line, there are no compile errors (I was using 1.8.0 from the command line).

I will lower the priority here since this is partially fixed.

Well there is another issue I noticed the other day with Groovy 1.8 and static inner classes.

When you have multiple static inner classes you get compile errors. If I recall the error is something to do with duplicate classes or something... I'll try to do some more testing on my end when I get a chance. This might be something to test on your end if your working on this....

The case is something like:

class Outer {
  static class Inner1 { }
  static class Inner2 { }
}

Still a problem, or at least the original comment is still a problem.

Travis, have you been able to narrow down the problem described in your comment? I have not been able to reproduce.

I have not had a chance to give this a test. Most of our team has switched to using Intellij so I haven't heard any complaints of this lately... We do plan on using the eclipse compiler via maven at that point so this could affect us then.

The original issue had to do with the core groovy compiler not compiling static inner classes correctly. Now it seems that is fixed but maybe there is a problem with multiple static inner classes. Could this be a problem in the core groovy compiler too? I'm not sure how greclipse uses the groovy compiler....

The "The constructor Outer.Inner() is undefined" is also a groovy 'bug'. I just raised http://jira.codehaus.org/browse/GROOVY-5080 - groovy incorrectly tags the generated constructor as synthetic.

You won't see it on the command line if you compile the java and groovy together in one step, you need to do a two part compile, the groovy and then java. That more closely mirrors the eclipse incremental build that shows the problem. An eclipse full build won't show the problem.

As for this:

class Outer {
  static class Inner1 { }
  static class Inner2 { }
}

Can't get it to fail for me, maybe we've picked up some fix in 1.8.3 that addressed something in this area. please open a new bug if you see something in this area.

Oh, and I've committed the fix for the groovy bug 5080 into our copy of groovyc, so that under greclipse we won't tag the constructors incorrectly.

This fails for me with the following code (all code in .groovy files):

 
package com.company.somepackage
public interface SomeInterface {
    SomeGroovyObject doSomething(SomeOtherGroovyObject param)
}

package com.company.somepackage
class SomeTestClass {
    void setup() {
        testObject.someProperty = new SomeInterface() {
            return new SomeGroovyObject()
        }
    }
}

The compiler gives an error like:

 
SomeTestClass.groovy (at line 1)
	package com.company.somepackage
	^
The type com.company.somepackage.SomeInterface$1 cannot be resolved. It is indirectly referenced from required .class files

I've tried this from Maven on both 2.5.2-01 and 2.6.0-SNAPSHOT of groovy-eclipse-compiler. I've also checked out groovy-eclipse-compiler from svn and built but it fails with the same error.

Hi Peter,

Can you maybe give me a complete failing project that shows this problem? The code above is missing SomeOtherGroovyObject and SomeGroovyObject - but even when I supply stub implementations of them, the setup() method shows a problem:

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
SomeTestClass.groovy: 13: unexpected token: return @ line 13, column 5.
   				return new SomeGroovyObject()

I dont get as far as a resolution error.