jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
GRECLIPSE
  • GRECLIPSE
  • GRECLIPSE-909 Groovy Quickfixes in the editor
  • GRECLIPSE-936

Better ordering for quick fixes

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Sub-task Sub-task
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1.0Release
  • Fix Version/s: 2.1.2Release
  • Component/s: Editor
  • Labels:
    None
  • Number of attachments :
    4

Description

When the quick fix dialog is shown, there should be some better ordering for potential fixes. This is particularly the case for the add import quick fix, which may have many types to propose.

Take a look at the class org.codehaus.groovy.eclipse.codeassist.proposals.Relevance, which calculates relevance for content assist. This may or may not be useful for you. In particular, you can look at how relevance is calculated for type proposals, in org.codehaus.groovy.eclipse.codeassist.processors.GroovyProposalTypeSearchRequestor.proposeImportableType()

It would be reasonable to refactor this logic into a separate class so that it would be accessible for quickfixes. If you go that way, then the logic from ...proposeNoImportType() and proposeConstructor() should be refactored out as well.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    fix_greclipse_936_minor_cleanup_v20110224_1341.patch
    24/Feb/11 12:46 PM
    12 kB
    Nieraj Singh
  2. Text File
    fix_greclipse_936_v20110219_2048.patch
    18/Feb/11 8:00 PM
    29 kB
    Nieraj Singh
  3. Text File
    fix_greclipse_936_v20110221_1704.patch
    21/Feb/11 4:08 PM
    29 kB
    Nieraj Singh
  4. Text File
    fix_greclipse_936_v20110221_1938.patch
    21/Feb/11 6:41 PM
    30 kB
    Nieraj Singh

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
No work has yet been logged on this issue.

People

  • Assignee:
    Nieraj Singh
    Reporter:
    Andrew Eisenberg
Vote (0)
Watch (0)

Dates

  • Created:
    15/Dec/10 11:56 AM
    Updated:
    24/Feb/11 1:39 PM
    Resolved:
    22/Feb/11 1:24 PM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.